Bring ARM templates up to date with their bicep counterparts #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathind-ms
approved these changes
May 19, 2023
shawncal
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
…ft#1094) ### Motivation and Context Although the source bicep file to deploy SK to Azure was updated to the latest appsettings.json format, the ARM templates it generates were not. The "Deploy to Azure" buttons use the ARM templates and currently deploy broken services. ### Description Generated ARM json files with the following commands: az bicep build -f sk-new.bicep az bicep build -f sk-existing-azureopenai.bicep az bicep build -f sk-existing-openai.bicep ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…ft#1094) ### Motivation and Context Although the source bicep file to deploy SK to Azure was updated to the latest appsettings.json format, the ARM templates it generates were not. The "Deploy to Azure" buttons use the ARM templates and currently deploy broken services. ### Description Generated ARM json files with the following commands: az bicep build -f sk-new.bicep az bicep build -f sk-existing-azureopenai.bicep az bicep build -f sk-existing-openai.bicep ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
…ft#1094) ### Motivation and Context Although the source bicep file to deploy SK to Azure was updated to the latest appsettings.json format, the ARM templates it generates were not. The "Deploy to Azure" buttons use the ARM templates and currently deploy broken services. ### Description Generated ARM json files with the following commands: az bicep build -f sk-new.bicep az bicep build -f sk-existing-azureopenai.bicep az bicep build -f sk-existing-openai.bicep ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Although the source bicep file to deploy SK to Azure was updated to the latest appsettings.json format, the ARM templates it generates were not. The "Deploy to Azure" buttons use the ARM templates and currently deploy broken services.
Description
Generated ARM json files with the following commands:
az bicep build -f sk-new.bicep
az bicep build -f sk-existing-azureopenai.bicep
az bicep build -f sk-existing-openai.bicep
Contribution Checklist
dotnet format