-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable retry logic integration tests #1096
Merged
lemillermicrosoft
merged 5 commits into
microsoft:main
from
lemillermicrosoft:518_retry_int
May 19, 2023
Merged
Enable retry logic integration tests #1096
lemillermicrosoft
merged 5 commits into
microsoft:main
from
lemillermicrosoft:518_retry_int
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
Issue or Pull requests regarding .NET code
kernel
Issues or pull requests impacting the core kernel
labels
May 19, 2023
Merged
5 tasks
lemillermicrosoft
added
the
PR: ready for review
All feedback addressed, ready for reviews
label
May 19, 2023
RogerBarreto
previously approved these changes
May 19, 2023
dluc
reviewed
May 19, 2023
lemillermicrosoft
added
the
PR: ready to merge
PR has been approved by all reviewers, and is ready to merge.
label
May 19, 2023
RogerBarreto
approved these changes
May 19, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context microsoft#420 skipped retry tests for OpenAI. It was noted that Azure SDK was an issue, however, I added a test for Azure OpenAI and it passes as expected as well. I know there are changes coming in the area. I'd like to re-enable the tests since they are passing to make sure functionality remains intact as design changes. ### Description Enable the previous test and clone for Azure OpenAI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kernel
Issues or pull requests impacting the core kernel
.NET
Issue or Pull requests regarding .NET code
PR: ready for review
All feedback addressed, ready for reviews
PR: ready to merge
PR has been approved by all reviewers, and is ready to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#420 skipped retry tests for OpenAI. It was noted that Azure SDK was an issue, however, I added a test for Azure OpenAI and it passes as expected as well. I know there are changes coming in the area. I'd like to re-enable the tests since they are passing to make sure functionality remains intact as design changes.
Description
Enable the previous test and clone for Azure OpenAI.
Contribution Checklist
dotnet format