Python: Add Azure Cognitive Search vector connector #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tawalke
added
enhancement
PR: in progress
|
@farzad528 Please advise. |
tot0
reviewed
May 25, 2023
python/semantic_kernel/connectors/memory/azure_cog_search/acs_utils.py
Outdated
Show resolved
Hide resolved
|
@farzad528 Will you review please. I want to ensure in line with new ACS features |
python/semantic_kernel/connectors/memory/azure_cog_search/acs_memory_store.py
Outdated
Show resolved
Hide resolved
… both key and RBAC credentials, remove class level search client, update function signatures to include optional acs configs-TEW
…reation to each memory store function -TEW
…re for upsert & search based upon ACS team feedback (part 3)-TEW
…emantic-kernel into azure-search-connector
…emantic-kernel into azure-search-connector
|
@mattmsft and @@farzad528: Made several updates from our conversations. Please review and advise as this is a Hot PR. |
dluc
pushed a commit
that referenced
this pull request
Jun 14, 2023
Azure Cognitive Search integration with Python SK
dluc
pushed a commit
that referenced
this pull request
Jun 14, 2023
Azure Cognitive Search integration with Python SK
|
@mattmsft ACS connector completion notes: The formatting and clean up commit to signal completion of the ACS connector for this PR was completed from yesterday. I noticed that the final commit to this PR is not reflective here for you. Please see commit: d749247 and feature branch: https://github.com/microsoft/semantic-kernel/tree/feature-azure-search |
nacharya1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Why is this change required?
Enable Azure Cognitive Search Vector functionality to Semantic Kernel
What problem does it solve?
Allow Semantic Kernel to leverage the Azure Cognitive Search vector search preview as connector
What scenario does it contribute to?
Persistent Memory connectors
Description
Leverage the Azure Cognitive Search preview of vector search capabilities by using the Azure Python SDK
Contribution Checklist
dotnet format