CopilotChat: Replace "SK" with "SemanticKernel" and add App Service Plan allowable values. #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianwyatt
added
the
PR: ready for review
|
Still doing some validation - hold merge until I've finished. |
adrianwyatt
changed the title
hathind-ms
previously approved these changes
May 19, 2023
|
This change is missing: Package URI from https://skaasdeploy.blob.core.windows.net/api/skaas.zip to be https://semantic-kernel-deploy.blob.core.windows.net/api/Semantic-Kernel.zip |
We'll need to standup another blob service and populate it. I wanted to not block these changes on that move. I'll look at that next. |
hathind-ms
previously approved these changes
May 19, 2023
glahaye
reviewed
May 19, 2023
samples/apps/copilot-chat-app/webapi/DeploymentTemplates/sk-existing-azureopenai.bicep
Outdated
Show resolved
Hide resolved
glahaye
reviewed
May 19, 2023
samples/apps/copilot-chat-app/webapi/DeploymentTemplates/sk-existing-openai.bicep
Outdated
Show resolved
Hide resolved
glahaye
reviewed
May 19, 2023
samples/apps/copilot-chat-app/webapi/DeploymentTemplates/sk-new.bicep
Outdated
Show resolved
Hide resolved
glahaye
reviewed
May 19, 2023
samples/apps/copilot-chat-app/webapi/DeploymentTemplates/main.bicep
Outdated
Show resolved
Hide resolved
…bicep Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
…w.bicep Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
…isting-azureopenai.bicep Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
glahaye
reviewed
May 19, 2023
samples/apps/copilot-chat-app/webapi/DeploymentTemplates/main.bicep
Outdated
Show resolved
Hide resolved
…isting-openai.bicep Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
…bicep Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
hathind-ms
previously approved these changes
May 19, 2023
hathind-ms
approved these changes
May 19, 2023
glahaye
approved these changes
May 19, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…lan allowable values. (microsoft#1109) ### Motivation and Context Remove most occurrences of "SK" from CopilotChat deployment ### Description - Renamed most occurrences of "SK" to either "SemanticKernel" or "SemKer" throughout CopilotChat - Updated App Plan SKUs with a list of allowed values. --------- Co-authored-by: Harleen Thind <39630244+hathind-ms@users.noreply.github.com> Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
…lan allowable values. (microsoft#1109) ### Motivation and Context Remove most occurrences of "SK" from CopilotChat deployment ### Description - Renamed most occurrences of "SK" to either "SemanticKernel" or "SemKer" throughout CopilotChat - Updated App Plan SKUs with a list of allowed values. --------- Co-authored-by: Harleen Thind <39630244+hathind-ms@users.noreply.github.com> Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Remove most occurrences of "SK" from CopilotChat deployment
Description