CopilotChat email body is the user intent and not the requested body. #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitri-ms
requested review from
lemillermicrosoft,
hathind-ms,
adrianwyatt,
teresaqhoang and
amsacha
hathind-ms
approved these changes
May 19, 2023
adrianwyatt
approved these changes
May 19, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…microsoft#1119) ### Motivation and Context By design, the planner prioritizes using the provided context variables over whatever is in the plan's state. In this case, the plan's state "input" was the requested body, but it was overridden by the provided context's "input" (user intent). To avoid this, we should call the planner without providing the existing context variables, unless we explicitly want to override what is in the plan's state. ### Description Pass in `newPlanContext` when invoking the plan, so the planner can have context about memory, skills, etc, but do not include context variables.
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
…microsoft#1119) ### Motivation and Context By design, the planner prioritizes using the provided context variables over whatever is in the plan's state. In this case, the plan's state "input" was the requested body, but it was overridden by the provided context's "input" (user intent). To avoid this, we should call the planner without providing the existing context variables, unless we explicitly want to override what is in the plan's state. ### Description Pass in `newPlanContext` when invoking the plan, so the planner can have context about memory, skills, etc, but do not include context variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
By design, the planner prioritizes using the provided context variables over whatever is in the plan's state. In this case, the plan's state "input" was the requested body, but it was overridden by the provided context's "input" (user intent). To avoid this, we should call the planner without providing the existing context variables, unless we explicitly want to override what is in the plan's state.
Description
Pass in
newPlanContextwhen invoking the plan, so the planner can have context about memory, skills, etc, but do not include context variables.Contribution Checklist
dotnet format