Rewrite how native skill functions are invoked #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
dluc
reviewed
May 23, 2023
shawncal
requested review from
dmytrostruk,
lemillermicrosoft,
SergeyMenshykh and
shawncal
lemillermicrosoft
previously approved these changes
May 23, 2023
dmytrostruk
approved these changes
May 23, 2023
The current approach involves exactly matching the target method against a fixed set of known signatures. I've revised it to instead be a little more dynamic, such that it instead just looks for valid parameters (e.g. currently up to one string and up to one SKContext) and valid return types (e.g. void, string, context, and tasks of each of those), and any combination of those is valid. This not only allows the implementation to be simplified and supports combinations that someone could reasonably expect to be valid (e.g. Func(context, string) rather than just Func(string, context)), but it also sets it up to easily allow for additional features to be added, e.g. parameters that match by name against context variables such that any number of parameters could be supported, non-string arguments once those are allowed in context variables, etc.
|
Great stuff! I cloned, played with this, ran all unit tests, integration tests. All looks good. |
shawncal
approved these changes
May 24, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context Simplify native function invocation and prepare for additional functionality. ### Description The current approach involves exactly matching the target method against a fixed set of known signatures. I've revised it to instead be a little more dynamic, such that it instead just looks for valid parameters (e.g. currently up to one string and up to one SKContext) and valid return types (e.g. void, string, context, and tasks of each of those), and any combination of those is valid. This not only allows the implementation to be simplified and supports combinations that someone could reasonably expect to be valid (e.g. Func(context, string) rather than just Func(string, context)), but it also sets it up to easily allow for additional features to be added, e.g. parameters that match by name against context variables such that any number of parameters could be supported, non-string arguments once those are allowed in context variables, etc. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 馃槃 cc: @dluc, @shawncal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Simplify native function invocation and prepare for additional functionality.
Description
The current approach involves exactly matching the target method against a fixed set of known signatures. I've revised it to instead be a little more dynamic, such that it instead just looks for valid parameters (e.g. currently up to one string and up to one SKContext) and valid return types (e.g. void, string, context, and tasks of each of those), and any combination of those is valid. This not only allows the implementation to be simplified and supports combinations that someone could reasonably expect to be valid (e.g. Func(context, string) rather than just Func(string, context)), but it also sets it up to easily allow for additional features to be added, e.g. parameters that match by name against context variables such that any number of parameters could be supported, non-string arguments once those are allowed in context variables, etc.
Contribution Checklist
dotnet formatcc: @dluc, @shawncal