Restructuring BaseService to handle FormData as body + adds Import Document is a No Response operation #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ang/semantic-kernel into extending-base-service
teresaqhoang
changed the title
glahaye
approved these changes
May 22, 2023
TaoChenOSU
approved these changes
May 22, 2023
teresaqhoang
added
the
PR: ready to merge
|
We can let this in now. I think moving forward it is better for us to have the base service know nothing about the other services that derives the base service. We can have the base service to provide multiple methods for different content types and respond types. |
hathind-ms
approved these changes
May 22, 2023
Yeah I agree, I think we also need a better way to handle operations that expect no response body (whether it's aligning all requests in the backend to return either a 202 Accepted or a 204 No Content) |
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…cument is a No Response operation (microsoft#1172) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Restructuring BaseService to handle FormData as body + adds Import Document is a No Response operation
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
…cument is a No Response operation (microsoft#1172) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Restructuring BaseService to handle FormData as body + adds Import Document is a No Response operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Restructuring BaseService to handle FormData as body + adds Import Document is a No Response operation