-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of OpenAI SDK directly #1197
Merged
markwallace-microsoft
merged 32 commits into
microsoft:experimental-java
from
brunoborges:refactor-openai-sdk
Jun 9, 2023
Merged
Make use of OpenAI SDK directly #1197
markwallace-microsoft
merged 32 commits into
microsoft:experimental-java
from
brunoborges:refactor-openai-sdk
Jun 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces confusion with the Azure OpenAI SDK.
@johnoliver there it goes. |
All fine, just need to resolve conflicts and update the samples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
johnoliver
previously approved these changes
May 25, 2023
@brunoborges has merge conflicts |
### Motivation and Context ### Description Opening a PR with initial CI changes to build and run tests against Java packages. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: joe-braley <joebraley@microsoft.com> Co-authored-by: Luigi96 <luiseduardom@microsoft.com> Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Complete the implementation of VolatileMemoryStoreTests ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Complete the implementation of VolatileMemoryStoreTests. Make implementation consistent with tests. Please note that I added equals and hashCode methods to Embedding, MemoryRecord, and MemoryRecordMetadata because these unit tests use assertEquals. Alternatively, I could have created methods in VolatileMemoryStoreTests to check equality. I'm good with either way. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] ~The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format`~ Java code follows AOSP style - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
### Motivation and Context ### Description Add command to PRs to properly format Java code. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
markwallace-microsoft
previously approved these changes
Jun 2, 2023
…nel into refactor-openai-sdk # Conflicts: # java/samples/pom.xml # java/semantickernel-connectors-parent/semantickernel-connectors/src/main/java/com/microsoft/semantickernel/connectors/ai/openai/textcompletion/OpenAITextCompletionBuilder.java # java/semantickernel-connectors-parent/semantickernel-connectors/src/main/java/com/microsoft/semantickernel/connectors/ai/openai/textembeddings/OpenAITextEmbeddingGenerationBuilder.java
3bfea6f
@markwallace-microsoft @johnoliver @milderhc hey folks, this PR is 100% ready to go. |
markwallace-microsoft
previously approved these changes
Jun 6, 2023
johnoliver
previously approved these changes
Jun 6, 2023
…nel into refactor-openai-sdk
Adjust dependency on samples. Fix sample code imports.
markwallace-microsoft
approved these changes
Jun 9, 2023
70d49fe
into
microsoft:experimental-java
6 checks passed
markwallace-microsoft
pushed a commit
that referenced
this pull request
Jun 12, 2023
This is a follow up on the PR #1197
This was referenced Aug 1, 2023
johnoliver
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
This PR removes the Azure Open AI Client wrapper originally created as a workaround. --------- Co-authored-by: Luigi Montoya <yayodelta@gmail.com> Co-authored-by: joe-braley <joebraley@microsoft.com> Co-authored-by: Luigi96 <luiseduardom@microsoft.com> Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com> Co-authored-by: John Oliver <1615532+johnoliver@users.noreply.github.com> Co-authored-by: David Grieve <dsgrieve@yahoo.com>
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
) This is a follow up on the PR microsoft#1197
johnoliver
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
This PR removes the Azure Open AI Client wrapper originally created as a workaround. --------- Co-authored-by: Luigi Montoya <yayodelta@gmail.com> Co-authored-by: joe-braley <joebraley@microsoft.com> Co-authored-by: Luigi96 <luiseduardom@microsoft.com> Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com> Co-authored-by: John Oliver <1615532+johnoliver@users.noreply.github.com> Co-authored-by: David Grieve <dsgrieve@yahoo.com>
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
) This is a follow up on the PR microsoft#1197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
java
Issue or PR regarding Java code
PR: ready to merge
PR has been approved by all reviewers, and is ready to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Azure Open AI Client wrapper originally created as a workaround.