Updating webkit values to relative percentage #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teresaqhoang
added
PR: ready to merge
teresaqhoang
changed the title
adrianwyatt
approved these changes
May 24, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context -webkit-fill-available is not widely supported across all browsers. It is a non-standard CSS value and doesn't work on Firefox (Mozilla) browsers. Changing this to a relative percentage to be more inclusive of all browsers. Scrollbars are unaffected and clamps are unaffected as they have a default fallback in moz Example in Firefox: 
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context -webkit-fill-available is not widely supported across all browsers. It is a non-standard CSS value and doesn't work on Firefox (Mozilla) browsers. Changing this to a relative percentage to be more inclusive of all browsers. Scrollbars are unaffected and clamps are unaffected as they have a default fallback in moz Example in Firefox: 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
-webkit-fill-available is not widely supported across all browsers. It is a non-standard CSS value and doesn't work on Firefox (Mozilla) browsers. Changing this to a relative percentage to be more inclusive of all browsers.
Scrollbars are unaffected and clamps are unaffected as they have a default fallback in moz
Example in Firefox:
