Qdrant: fix skipping upserts #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tawalke This code is UNTESTED (hence the "Draft" status). Can you please take over this PR, test with a qdrant instance? |
github-actions
bot
added
.NET
glahaye
approved these changes
May 25, 2023
shawncal
force-pushed
the
qdrant-upsert-fix
branch
from
c8ed511
to
151760a
Compare
shawncal
force-pushed
the
qdrant-upsert-fix
branch
from
151760a
to
f5ecb0e
Compare
shawncal
added a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Description In the Qdrant connector, during Upsert(), it checks whether the vector already exists in the db; if so, it calls `continue` and skips upserting. The expected behavior of Upsert() is Insert+Update, but currently only the insert is working updates are explicitly skipped. Resolves microsoft#1035 Also includes some minor cleanup on the internal request builder classes: - DeleteRange - UpsertRange ...allow you to create the Builder, add all operations, and Build() in a single statement, so you never have to hold an instance of the Builder as a var just to operate a loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the Qdrant connector, during Upsert(), it checks whether the vector already exists in the db; if so, it calls
continueand skips upserting. The expected behavior of Upsert() is Insert+Update, but currently only the insert is working updates are explicitly skipped.Resolves #1035
Also includes some minor cleanup on the internal request builder classes:
...allow you to create the Builder, add all operations, and Build() in a single statement, so you never have to hold an instance of the Builder as a var just to operate a loop.
Contribution Checklist
dotnet format