-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to run .NET6 projects with .NET 7 #1210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
Issue or Pull requests regarding .NET code
samples
labels
May 25, 2023
dluc
changed the title
Allow to run .NET projects with .NET 7
Allow to run .NET6 projects with .NET 7
May 25, 2023
shawncal
approved these changes
May 25, 2023
shawncal
force-pushed
the
dluc159chatfixes
branch
from
May 25, 2023 20:08
9b48cfa
to
af697b3
Compare
hathind-ms
approved these changes
May 25, 2023
@dluc - LGTM |
adrianwyatt
approved these changes
May 25, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context When launching one of these SK .NET projects * samples/apps/copilot-chat-app/importdocument/**ImportDocument** * samples/apps/copilot-chat-app/webapi/**CopilotChatWebApi** * samples/dotnet/KernelBuilder/**KernelBuilder** * samples/dotnet/kernel-syntax-examples/**KernelSyntaxExamples** * samples/dotnet/graph-api-skills/**MsGraphSkillsExample** * samples/dotnet/openapi-skills/**OpenApiSkillsExample** on a machine where only .NET 7 is installed, the runtime throws this error: ``` You must install or update .NET to run this application. App: samples/dotnet/kernel-syntax-examples/bin/Debug/net6.0/KernelSyntaxExamples Architecture: ... Framework: 'Microsoft.NETCore.App', version '6.0.0' (x64) .NET location: ... The following frameworks were found: 7.0.5 at [...] Learn about framework resolution: https://aka.ms/dotnet/app-launch-failed To install missing framework, download: https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=6.0.0&... ``` ### Description Add roll-forward behavior, which is also described in the https://aka.ms/dotnet/app-launch-failed link mentioned in the error message. Note: since using this option lets the application run on a different framework version than the one for which it was designed, it may result in unintended behavior due to changes between versions of a framework. We should keep testing all the projects on newer versions. Co-authored-by: Harleen Thind <39630244+hathind-ms@users.noreply.github.com> Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com>
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context When launching one of these SK .NET projects * samples/apps/copilot-chat-app/importdocument/**ImportDocument** * samples/apps/copilot-chat-app/webapi/**CopilotChatWebApi** * samples/dotnet/KernelBuilder/**KernelBuilder** * samples/dotnet/kernel-syntax-examples/**KernelSyntaxExamples** * samples/dotnet/graph-api-skills/**MsGraphSkillsExample** * samples/dotnet/openapi-skills/**OpenApiSkillsExample** on a machine where only .NET 7 is installed, the runtime throws this error: ``` You must install or update .NET to run this application. App: samples/dotnet/kernel-syntax-examples/bin/Debug/net6.0/KernelSyntaxExamples Architecture: ... Framework: 'Microsoft.NETCore.App', version '6.0.0' (x64) .NET location: ... The following frameworks were found: 7.0.5 at [...] Learn about framework resolution: https://aka.ms/dotnet/app-launch-failed To install missing framework, download: https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=6.0.0&... ``` ### Description Add roll-forward behavior, which is also described in the https://aka.ms/dotnet/app-launch-failed link mentioned in the error message. Note: since using this option lets the application run on a different framework version than the one for which it was designed, it may result in unintended behavior due to changes between versions of a framework. We should keep testing all the projects on newer versions. Co-authored-by: Harleen Thind <39630244+hathind-ms@users.noreply.github.com> Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
.NET
Issue or Pull requests regarding .NET code
PR: ready for review
All feedback addressed, ready for reviews
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When launching one of these SK .NET projects
on a machine where only .NET 7 is installed, the runtime throws this error:
Description
Add roll-forward behavior, which is also described in the https://aka.ms/dotnet/app-launch-failed link mentioned in the error message.
Note: since using this option lets the application run on a different framework version than the one for which it was designed, it may result in unintended behavior due to changes between versions of a framework. We should keep testing all the projects on newer versions.