Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvements to Copilot chat setup and docs #1211

Merged
merged 5 commits into from May 25, 2023
Merged

Some improvements to Copilot chat setup and docs #1211

merged 5 commits into from May 25, 2023

Conversation

dluc
Copy link
Collaborator

@dluc dluc commented May 25, 2023

  • align ".env.example" file name to other sample apps
  • add missing JSON comma for first setup
  • improve markdown readability, also for chunker/indexer apps
  • some docs improvements

@dluc
Some improvements to Copilot chat setup
43efaed 
* align ".env.example" name to other sample apps
* add missing JSON comma for first setup
* improve markdown readability, also for chunker/indexer apps
* some docs improvements
@dluc dluc added the PR: ready for review All feedback addressed, ready for reviews label May 25, 2023
lemillermicrosoft
lemillermicrosoft previously approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@lemillermicrosoft lemillermicrosoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1205 also adds some improvements to setup in vscode.

@dluc dluc dismissed lemillermicrosoft’s stale review May 25, 2023 17:45

Making sure @adrianwyatt takes a look before accidental merges

@adrianwyatt adrianwyatt enabled auto-merge (squash) May 25, 2023 23:19
@adrianwyatt adrianwyatt added PR: ready to merge PR has been approved by all reviewers, and is ready to merge. and removed PR: ready for review All feedback addressed, ready for reviews labels May 25, 2023
@adrianwyatt adrianwyatt merged commit ed46631 into microsoft:main May 25, 2023
16 checks passed
@dluc dluc deleted the dluc160chatfixes branch June 14, 2023 01:14
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
@dluc @lemillermicrosoft @adrianwyatt
Some improvements to Copilot chat setup and docs (microsoft#1211)
32f294a 
* align ".env.example" file name to other sample apps
* add missing JSON comma for first setup
* improve markdown readability, also for chunker/indexer apps
* some docs improvements

Co-authored-by: Lee Miller <lemiller@microsoft.com>
Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com>
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
@dluc @lemillermicrosoft @adrianwyatt
Some improvements to Copilot chat setup and docs (microsoft#1211)
0cb9012 
* align ".env.example" file name to other sample apps
* add missing JSON comma for first setup
* improve markdown readability, also for chunker/indexer apps
* some docs improvements

Co-authored-by: Lee Miller <lemiller@microsoft.com>
Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianwyatt adrianwyatt adrianwyatt approved these changes

@lemillermicrosoft lemillermicrosoft lemillermicrosoft left review comments

@hathind-ms hathind-ms Awaiting requested review from hathind-ms

Assignees

@adrianwyatt adrianwyatt

Labels
PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dluc @lemillermicrosoft @adrianwyatt