Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make optional strings default to null instead of empty #1259

Merged
merged 2 commits into from
May 30, 2023
Merged

Make optional strings default to null instead of empty #1259

merged 2 commits into from
May 30, 2023

Conversation

stephentoub
Copy link
Member

Motivation and Context

Null is the typical / expected default value for optional strings in cases like this.

Description

Contribution Checklist

@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel.core labels May 28, 2023
@stephentoub
Make optional strings default to null instead of empty
9da965e 
Null is the typical / expected default value for optional strings in cases like this.
@github-actions github-actions bot added kernel Issues or pull requests impacting the core kernel samples labels May 28, 2023
@glahaye glahaye requested a review from dluc May 30, 2023 18:29
@shawncal shawncal merged commit 03de0a3 into microsoft:main May 30, 2023
15 checks passed
@stephentoub stephentoub deleted the nullstringdefault branch May 30, 2023 21:33
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
@stephentoub
Make optional strings default to null instead of empty (microsoft#1259)
f107fcd 
### Motivation and Context
Null is the typical / expected default value for optional strings in
cases like this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawncal shawncal shawncal approved these changes

@dluc dluc Awaiting requested review from dluc

Assignees
No one assigned
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stephentoub @shawncal