Http consistency: Pinecone #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
SergeyMenshykh
added
the
PR: ready for review
dmytrostruk
reviewed
May 30, 2023
dotnet/src/Connectors/Connectors.Memory.Pinecone/PineconeKernelBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Pinecone/PineconeKernelBuilderExtensions.cs
Show resolved
Hide resolved
SergeyMenshykh
added
PR: paused
…lBuilderExtensions.cs Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
+1 |
lemillermicrosoft
approved these changes
Jun 7, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Description This PR introduces the following changes: 1. The PineconeClient class accepts a custom HTTP client, allowing the hosting application/client code to provide their own instances. 2. A new extension method, `WithPineconeMemoryStore`, has been added to the `KernelBuilder` class. This method simplifies the registration of the Pinecone memory store, aligns the registration process with other connector registrations, and enforces the usage of an HTTP client and retry handlers configured in the SK SDK. 3. The global static `HttpHandlers` class is removed because it goes against the agreed approach for the SK SDK's HTTP stack that assumes the usage of a custom HTTP client for fine-tuning instead of relying on global static variables. Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the following changes:
The PineconeClient class accepts a custom HTTP client, allowing the hosting application/client code to provide their own instances.
A new extension method,
WithPineconeMemoryStore, has been added to theKernelBuilderclass. This method simplifies the registration of the Pinecone memory store, aligns the registration process with other connector registrations, and enforces the usage of an HTTP client and retry handlers configured in the SK SDK.The global static
HttpHandlersclass is removed because it goes against the agreed approach for the SK SDK's HTTP stack that assumes the usage of a custom HTTP client for fine-tuning instead of relying on global static variables.Contribution Checklist
dotnet format