Http consistency: Qdrant #1385
Merged
Http consistency: Qdrant #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… client or a custom one.
github-actions
bot
added
.NET
SergeyMenshykh
added
.NET
SergeyMenshykh
requested review from
awharrison-28,
lemillermicrosoft and
shawncal
SergeyMenshykh
added
the
PR: ready for review
lemillermicrosoft
approved these changes
Jun 9, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Description This PR brings the following changes: - The Qdrant-related classes, namely QdrantMemoryStore and QdrantVectorDbClient, have extended support for various creation methods based on Qdrant endpoint, HttpClient, or both. - The KernelBuilder class has new extension methods called "WithQdrantMemoryStore" that simplify the registration of the Qdrant memory store. These methods align the registration process with other connector registrations, enforce the use of a HttpClient with the preconfigured retry handler, and allow the hosting application to provide a custom HttpClient if needed. - Minor bug fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings the following changes:
The Qdrant-related classes, namely QdrantMemoryStore and QdrantVectorDbClient, have extended support for various creation methods based on Qdrant endpoint, HttpClient, or both.
The KernelBuilder class has new extension methods called "WithQdrantMemoryStore" that simplify the registration of the Qdrant memory store. These methods align the registration process with other connector registrations, enforce the use of a HttpClient with the preconfigured retry handler, and allow the hosting application to provide a custom HttpClient if needed.
Minor bug fix.
Contribution Checklist
dotnet format