Enabling Plan Edits in Copilot #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teresaqhoang
added
the
PR: ready for review
teresaqhoang
requested review from
TaoChenOSU,
lemillermicrosoft,
gitri-ms,
dehoward and
adrianwyatt
dehoward
reviewed
Jun 12, 2023
samples/apps/copilot-chat-app/webapp/src/components/chat/plan-viewer/PlanStepCard.tsx
Show resolved
Hide resolved
dehoward
previously approved these changes
Jun 12, 2023
samples/apps/copilot-chat-app/webapp/src/components/chat/plan-viewer/PlanViewer.tsx
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapp/src/components/chat/plan-viewer/PlanStepCard.tsx
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapp/src/components/chat/plan-viewer/PlanStepInput.tsx
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapp/src/components/chat/ChatHistoryItem.tsx
Outdated
Show resolved
Hide resolved
teresaqhoang
added
PR: ready to merge
dehoward
added
PR: feedback to address
teresaqhoang
added
PR: ready to merge
dehoward
previously approved these changes
Jun 12, 2023
TaoChenOSU
previously approved these changes
Jun 12, 2023
samples/apps/copilot-chat-app/webapi/CopilotChat/Models/ProposedPlan.cs
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapi/CopilotChat/Models/ProposedPlan.cs
Outdated
Show resolved
Hide resolved
TaoChenOSU
previously approved these changes
Jun 12, 2023
adrianwyatt
approved these changes
Jun 12, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context This PR enables user to edit a plan before approving or rejecting it: - User can edit any of the input value fields - User can delete step(s) (If SequentialPlanner is enabled). Deletion is disabled when there is only one step. When plan is returned to the Kernel, the chat message will be updated in the history repository to reflect the new plan state. ### Description This PR also contains optimizations for methods handling user actions on proposed plan and plan schema changes to enable the above. Chat History will also now reflect any actions the user took on the plan. Input Edit Mode: <img width="665" alt="image" src="https://github.com/microsoft/semantic-kernel/assets/125500434/31b7a5b5-9ca0-432a-bde1-3141e0e8e76f"> Editing Action Plan (inputs only):  Editing SequentialPlanner (inputs and deleting step):  Added 'NoOp' Plan state, where proposedPlan becomes unactionable if app state changes before user approves or rejects the plan. Potential reasons for unstable state: required plug-in no longer enabled, access permissions changed, etc.  > Note: there's some hallucinations with SequentialPlanner, but planner default is Action. SequentialPlanner stabilizations will continue in another PR
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context This PR enables user to edit a plan before approving or rejecting it: - User can edit any of the input value fields - User can delete step(s) (If SequentialPlanner is enabled). Deletion is disabled when there is only one step. When plan is returned to the Kernel, the chat message will be updated in the history repository to reflect the new plan state. ### Description This PR also contains optimizations for methods handling user actions on proposed plan and plan schema changes to enable the above. Chat History will also now reflect any actions the user took on the plan. Input Edit Mode: <img width="665" alt="image" src="https://github.com/microsoft/semantic-kernel/assets/125500434/31b7a5b5-9ca0-432a-bde1-3141e0e8e76f"> Editing Action Plan (inputs only):  Editing SequentialPlanner (inputs and deleting step):  Added 'NoOp' Plan state, where proposedPlan becomes unactionable if app state changes before user approves or rejects the plan. Potential reasons for unstable state: required plug-in no longer enabled, access permissions changed, etc.  > Note: there's some hallucinations with SequentialPlanner, but planner default is Action. SequentialPlanner stabilizations will continue in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR enables user to edit a plan before approving or rejecting it:
When plan is returned to the Kernel, the chat message will be updated in the history repository to reflect the new plan state.
Description
This PR also contains optimizations for methods handling user actions on proposed plan and plan schema changes to enable the above.
Chat History will also now reflect any actions the user took on the plan.
Input Edit Mode:
Editing Action Plan (inputs only):
Editing SequentialPlanner (inputs and deleting step):
Added 'NoOp' Plan state, where proposedPlan becomes unactionable if app state changes before user approves or rejects the plan. Potential reasons for unstable state: required plug-in no longer enabled, access permissions changed, etc.
Contribution Checklist
dotnet format