Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print Chat History at the end of Notebooks #1412

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Print Chat History at the end of Notebooks #1412

merged 2 commits into from
Jun 12, 2023

Conversation

robinmanuelthiel
Copy link
Member

@robinmanuelthiel robinmanuelthiel commented Jun 11, 2023 •
edited
Loading

Motivation and Context

When working through the notebooks, I had the feeling that printing the chat history at the end, makes it much clearer how it actually looks like after a bunch of chats. I would like to see this added for everyone.

Description

Printing the chat history in the Notebooks at the end of the Planner section

Contribution Checklist

@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code samples labels Jun 11, 2023
@alexchaomander alexchaomander added the python Pull requests for the Python Semantic Kernel label Jun 12, 2023
@alexchaomander alexchaomander self-requested a review June 12, 2023 16:11
alexchaomander
alexchaomander approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@alexchaomander alexchaomander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! Printing the chat history helps communicate what has happened throughout the course of the chat!

@alexchaomander alexchaomander added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label Jun 12, 2023
@github-actions github-actions bot removed the python Pull requests for the Python Semantic Kernel label Jun 12, 2023
@lemillermicrosoft lemillermicrosoft enabled auto-merge (squash) June 12, 2023 20:04
@lemillermicrosoft lemillermicrosoft merged commit eafe8c7 into microsoft:main Jun 12, 2023
15 checks passed
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
@robinmanuelthiel
Print Chat History at the end of Notebooks (microsoft#1412)
36b89ab 
### Motivation and Context
When working through the notebooks, I had the feeling that printing the
chat history at the end, makes it much clearer how it actually looks
like after a bunch of chats. I would like to see this added for
everyone.


### Description
Printing the chat history in the Notebooks at the end of the _Planner_
section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexchaomander alexchaomander alexchaomander approved these changes

Assignees
No one assigned
Labels
.NET Issue or Pull requests regarding .NET code PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robinmanuelthiel @alexchaomander @lemillermicrosoft