Http consistency: Azure Cognitive Search Memory #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
SergeyMenshykh
changed the title
SergeyMenshykh
added
the
PR: ready for review
lemillermicrosoft
previously approved these changes
Jun 14, 2023
...nnectors/Connectors.UnitTests/Memory/AzureCognitiveSearch/AzureCognitiveSearchMemoryTests.cs
Outdated
Show resolved
Hide resolved
...nnectors/Connectors.Memory.AzureCognitiveSearch/AzureSearchServiceKernelBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…veSearch/AzureCognitiveSearchMemoryTests.cs Co-authored-by: Lee Miller <lemiller@microsoft.com>
…zureSearchServiceKernelBuilderExtensions.cs Co-authored-by: Lee Miller <lemiller@microsoft.com>
…hykh/semantic-kernel into http-consistency-acsm
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Description This pull request includes the following updates: * The AzureCognitiveSearchMemory class is extended to support a custom HttpClient, if one is provided. * Two overloaded extension methods, 'WithAzureAzureCognitiveSearchMemory', are added to the KernelBuilder class to simplify registration of the Azure Cognitive Search Memory store. These methods align the registration process with other connector registrations, enforce usage of a HttpClient with the preconfigured retry handler, and enable the hosting application to supply a custom HttpClient if required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes the following updates:
The AzureCognitiveSearchMemory class is extended to support a custom HttpClient, if one is provided.
Two overloaded extension methods, 'WithAzureAzureCognitiveSearchMemory', are added to the KernelBuilder class to simplify registration of the Azure Cognitive Search Memory store. These methods align the registration process with other connector registrations, enforce usage of a HttpClient with the preconfigured retry handler, and enable the hosting application to supply a custom HttpClient if required.
Contribution Checklist
dotnet format