Fix ESLint in samples/apps #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehoward
added
PR: ready for review
dehoward
requested review from
dluc,
TaoChenOSU,
shawncal,
adrianwyatt and
teresaqhoang
adrianwyatt
added
the
PR: in progress
dehoward
removed
the
PR: in progress
TaoChenOSU
reviewed
Jun 15, 2023
teresaqhoang
previously approved these changes
Jun 15, 2023
dehoward
added
PR: ready to merge
TaoChenOSU
previously approved these changes
Jun 21, 2023
TaoChenOSU
approved these changes
Jun 21, 2023
teresaqhoang
approved these changes
Jun 21, 2023
shawncal
added a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> correctly using ESLint in our sample apps will help us - follow best practices, - cut down on bugs that the linter can catch, and - enforce a unified style ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> - adds `.env.local` to each app to disable ESLint in all environments - temporary until the violations are fixed in the app - this seemed to be the easiest way to disable ESLint without folks having to do anything, open to suggestions here. - this is needed because now the build picks up on our config file and will fail since there are currently violations - adds a `package.json` to `samples/apps` for the shared dependencies needed for running `eslint` - adds the `npm run lint` script and `eslint` package to apps where not already present - removes unneeded ESLint config/dependencies from CopilotChat - renames `.eslingrc.js` to `.eslintrc.js` ### Note **this doesn't start enforcing ESLint anywhere or fix any violations**, and rather just fixes the config so that we can begin to correct the errors. there are quite a number of violations just in CopilotChat alone:  `eslint --fix` can fix about half of these, albeit we should review these changes carefully if used. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [X] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄 --------- Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> correctly using ESLint in our sample apps will help us - follow best practices, - cut down on bugs that the linter can catch, and - enforce a unified style ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> - adds `.env.local` to each app to disable ESLint in all environments - temporary until the violations are fixed in the app - this seemed to be the easiest way to disable ESLint without folks having to do anything, open to suggestions here. - this is needed because now the build picks up on our config file and will fail since there are currently violations - adds a `package.json` to `samples/apps` for the shared dependencies needed for running `eslint` - adds the `npm run lint` script and `eslint` package to apps where not already present - removes unneeded ESLint config/dependencies from CopilotChat - renames `.eslingrc.js` to `.eslintrc.js` ### Note **this doesn't start enforcing ESLint anywhere or fix any violations**, and rather just fixes the config so that we can begin to correct the errors. there are quite a number of violations just in CopilotChat alone:  `eslint --fix` can fix about half of these, albeit we should review these changes carefully if used. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [X] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄 --------- Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> correctly using ESLint in our sample apps will help us - follow best practices, - cut down on bugs that the linter can catch, and - enforce a unified style ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> - adds `.env.local` to each app to disable ESLint in all environments - temporary until the violations are fixed in the app - this seemed to be the easiest way to disable ESLint without folks having to do anything, open to suggestions here. - this is needed because now the build picks up on our config file and will fail since there are currently violations - adds a `package.json` to `samples/apps` for the shared dependencies needed for running `eslint` - adds the `npm run lint` script and `eslint` package to apps where not already present - removes unneeded ESLint config/dependencies from CopilotChat - renames `.eslingrc.js` to `.eslintrc.js` ### Note **this doesn't start enforcing ESLint anywhere or fix any violations**, and rather just fixes the config so that we can begin to correct the errors. there are quite a number of violations just in CopilotChat alone:  `eslint --fix` can fix about half of these, albeit we should review these changes carefully if used. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [X] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄 --------- Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> correctly using ESLint in our sample apps will help us - follow best practices, - cut down on bugs that the linter can catch, and - enforce a unified style ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> - adds `.env.local` to each app to disable ESLint in all environments - temporary until the violations are fixed in the app - this seemed to be the easiest way to disable ESLint without folks having to do anything, open to suggestions here. - this is needed because now the build picks up on our config file and will fail since there are currently violations - adds a `package.json` to `samples/apps` for the shared dependencies needed for running `eslint` - adds the `npm run lint` script and `eslint` package to apps where not already present - removes unneeded ESLint config/dependencies from CopilotChat - renames `.eslingrc.js` to `.eslintrc.js` ### Note **this doesn't start enforcing ESLint anywhere or fix any violations**, and rather just fixes the config so that we can begin to correct the errors. there are quite a number of violations just in CopilotChat alone:  `eslint --fix` can fix about half of these, albeit we should review these changes carefully if used. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [X] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄 --------- Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
correctly using ESLint in our sample apps will help us
Description
.env.localto each app to disable ESLint in all environmentspackage.jsontosamples/appsfor the shared dependencies needed for runningeslintnpm run lintscript andeslintpackage to apps where not already present.eslingrc.jsto.eslintrc.jsNote
this doesn't start enforcing ESLint anywhere or fix any violations, and rather just fixes the config so that we can begin to correct the errors.
there are quite a number of violations just in CopilotChat alone:
eslint --fixcan fix about half of these, albeit we should review these changes carefully if used.Contribution Checklist
dotnet format