-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Http consistency: OpenAPI skills #1521
Merged
lemillermicrosoft
merged 6 commits into
microsoft:main
from
SergeyMenshykh:relax-openapi-parsing-error-check
Jun 20, 2023
Merged
Http consistency: OpenAPI skills #1521
lemillermicrosoft
merged 6 commits into
microsoft:main
from
SergeyMenshykh:relax-openapi-parsing-error-check
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42b8b7e
to
b7f3a02
Compare
2. Propagating the IgnoreNonCompliantErrors flag to all ImportOpenAPI* and ImportChatGpt* extension methods.
e772d93
to
d7f3f62
Compare
lemillermicrosoft
approved these changes
Jun 16, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation, Context, and Description 1. In some cases, OpenAPI documents imported as OpenAPI skills or ChatGPT plugins may be malformed or non-compliant. However, they can still be processed and imported, even with minor differences from OpenAPI specification. To enable the import of these documents, the OpenAPI functionality error handling has been relaxed. Instead of halting the entire operation, parsing errors in the OpenAPI documents are skipped and logged. 2. The HTTP stack for OpenAPI skills aligned with connectors by offering two options: - using the internal SK HTTP client using provided configuration during Kernel building. - accepting a custom/external HTTP client, giving hosting applications/client code the freedom to use their own instance. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Lee Miller <lemiller@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kernel
Issues or pull requests impacting the core kernel
.NET
Issue or Pull requests regarding .NET code
PR: breaking change
Pull requests that introduce breaking changes
PR: ready for review
All feedback addressed, ready for reviews
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation, Context, and Description
Contribution Checklist
dotnet format