Python: Add option for Azure OpenAI to notebook sample 06 #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexchaomander
approved these changes
Jun 16, 2023
alexchaomander
added
the
PR: ready to merge
github-actions
bot
removed
the
python
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…1529) ### Motivation and Context This is addressing issue [1528](microsoft#1528) ### Description In the Jupyter notebook for Python sample [06-memory-and-embeddings](https://github.com/microsoft/semantic-kernel/blob/main/samples/notebooks/python/06-memory-and-embeddings.ipynb), I updated the sample to include support for Azure OpenAI. This includes: - Importing classes for AzureTextCompletion and AzureTextEmbedding, - Adding a switch to choose OpenAI or Azure OpenAI Service. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is addressing issue 1528
Description
In the Jupyter notebook for Python sample 06-memory-and-embeddings, I updated the sample to include support for Azure OpenAI.
This includes:
Contribution Checklist
dotnet format