Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CopilotChat: add missing container #1533

Merged
merged 3 commits into from
Jun 17, 2023
Merged

CopilotChat: add missing container #1533

merged 3 commits into from
Jun 17, 2023

Conversation

hario90
Copy link
Contributor

@hario90 hario90 commented Jun 17, 2023

Motivation and Context

This fixes an issue with uploading documents from the copilot chat sample app when Azure Cosmos DB resources are used.

Description

The chatmemorysources Cosmos DB container referenced in the web API appsettings.json was missing from the bicep template and this caused the "resource not found" error.

Contribution Checklist

@hario90 hario90 requested a review from a team as a code owner June 17, 2023 00:14
@hario90 hario90 linked an issue Jun 17, 2023 that may be closed by this pull request
Failed to upload document Details: Error: 500: Internal Server Error #1402
Closed
@adrianwyatt adrianwyatt changed the title add missing container CopilotChat: add missing container Jun 17, 2023
craigomatic
craigomatic approved these changes Jun 17, 2023
View reviewed changes
Copy link
Contributor

@craigomatic craigomatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and as we validated offline in advance of the PR, this will now deploy the missing chatmemorysources container to CosmosDB

@craigomatic craigomatic added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label Jun 17, 2023
@adrianwyatt adrianwyatt added this pull request to the merge queue Jun 17, 2023
Merged via the queue into microsoft:main with commit cb8c572 Jun 17, 2023
7 checks passed
@adrianwyatt adrianwyatt mentioned this pull request Jun 19, 2023
Merged
adrianwyatt added a commit that referenced this pull request Jun 19, 2023
@adrianwyatt
CopilotChat: Update main.json to reflect changes in main.bicep (#1557)
5c68523 
### Motivation and Context
main.bicep changes from
#1533 did not get built
into main.json

### Description
- rebuild main.json from current main.bicep
markwallace-microsoft pushed a commit to markwallace-microsoft/semantic-kernel that referenced this pull request Jun 23, 2023
@hario90 @craigomatic
@adrianwyatt @markwallace-microsoft
CopilotChat: add missing container (microsoft#1533)
b3ecccc 
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

This fixes an
[issue](microsoft#1402) with
uploading documents from the copilot chat sample app when Azure Cosmos
DB resources are used.

### Description
The `chatmemorysources` Cosmos DB container referenced in the web API
appsettings.json was missing from the bicep template and this caused the
"resource not found" error.


### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

Co-authored-by: Craig Presti <146438+craigomatic@users.noreply.github.com>
Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com>
@evchaki evchaki added this to the Sprint 33 milestone Jun 30, 2023
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
@hario90 @craigomatic @adrianwyatt
CopilotChat: add missing container (microsoft#1533)
970334a 
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

This fixes an
[issue](microsoft#1402) with
uploading documents from the copilot chat sample app when Azure Cosmos
DB resources are used.

### Description
The `chatmemorysources` Cosmos DB container referenced in the web API
appsettings.json was missing from the bicep template and this caused the
"resource not found" error.


### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

Co-authored-by: Craig Presti <146438+craigomatic@users.noreply.github.com>
Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com>
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
@adrianwyatt
CopilotChat: Update main.json to reflect changes in main.bicep (micro…
b6a21be 
…soft#1557)

### Motivation and Context
main.bicep changes from
microsoft#1533 did not get built
into main.json

### Description
- rebuild main.json from current main.bicep
alliscode pushed a commit to microsoft/chat-copilot that referenced this pull request Jul 19, 2023
@adrianwyatt
CopilotChat: Update main.json to reflect changes in main.bicep (#1557)
333fc4d 
### Motivation and Context
main.bicep changes from
microsoft/semantic-kernel#1533 did not get built
into main.json

### Description
- rebuild main.json from current main.bicep
@hario90 hario90 deleted the 1402-fix-upload-failure branch August 16, 2023 16:30
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
@hario90 @craigomatic @adrianwyatt
CopilotChat: add missing container (microsoft#1533)
842d508 
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

This fixes an
[issue](microsoft#1402) with
uploading documents from the copilot chat sample app when Azure Cosmos
DB resources are used.

### Description
The `chatmemorysources` Cosmos DB container referenced in the web API
appsettings.json was missing from the bicep template and this caused the
"resource not found" error.


### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

Co-authored-by: Craig Presti <146438+craigomatic@users.noreply.github.com>
Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigomatic craigomatic craigomatic approved these changes

@adrianwyatt adrianwyatt adrianwyatt approved these changes

Assignees
No one assigned
Labels
PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
No open projects
Apps & Services Semantic Kernel
Status: Done
Milestone
Sprint 33
Development

Successfully merging this pull request may close these issues.

Failed to upload document Details: Error: 500: Internal Server Error
4 participants
@hario90 @craigomatic @adrianwyatt @evchaki