Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http consistency: HttpSkill, BingConnector, GoogleConnector, and WebFileDownloadSkill #1551

Merged
merged 4 commits into from
Jun 20, 2023

Conversation

SergeyMenshykh
Copy link
Member

Description

The HttpSkill, BingConnector, GoogleConnector, and WebFileDownloadSkill classes have been modified to accept an instance of an HTTP client, allowing hosting applications/client code the freedom to use their own instance if needed.

Contribution Checklist

@SergeyMenshykh SergeyMenshykh requested a review from a team as a code owner June 19, 2023 16:00
@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels Jun 19, 2023
@SergeyMenshykh SergeyMenshykh added the PR: ready for review All feedback addressed, ready for reviews label Jun 19, 2023
…loadSkill` classes have been modified to support the usage of either an internal or an external HTTP client.
@shawncal shawncal enabled auto-merge June 19, 2023 18:42
@SergeyMenshykh SergeyMenshykh linked an issue Jun 20, 2023 that may be closed by this pull request
@shawncal shawncal added this pull request to the merge queue Jun 20, 2023
Merged via the queue into microsoft:main with commit ac3d655 Jun 20, 2023
10 checks passed
@SergeyMenshykh SergeyMenshykh linked an issue Jun 20, 2023 that may be closed by this pull request
@evchaki evchaki added this to the Sprint 33 milestone Jun 30, 2023
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
…ileDownloadSkill (microsoft#1551)

### Description
The HttpSkill, BingConnector, GoogleConnector, and WebFileDownloadSkill
classes have been modified to accept an instance of an HTTP client,
allowing hosting applications/client code the freedom to use their own
instance if needed.

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

Co-authored-by: Lee Miller <lemiller@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix HttpClient usage for AI services/connectors Semantic Kernel needs a consistent story around HttpClient
4 participants