Http consistency: HttpSkill, BingConnector, GoogleConnector, and WebFileDownloadSkill #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
SergeyMenshykh
added
the
PR: ready for review
shawncal
approved these changes
Jun 19, 2023
…loadSkill` classes have been modified to support the usage of either an internal or an external HTTP client.
shawncal
force-pushed
the
http-consistency-skills
branch
from
7b79fde
to
9af9f79
Compare
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…ileDownloadSkill (microsoft#1551) ### Description The HttpSkill, BingConnector, GoogleConnector, and WebFileDownloadSkill classes have been modified to accept an instance of an HTTP client, allowing hosting applications/client code the freedom to use their own instance if needed. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 Co-authored-by: Lee Miller <lemiller@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The HttpSkill, BingConnector, GoogleConnector, and WebFileDownloadSkill classes have been modified to accept an instance of an HTTP client, allowing hosting applications/client code the freedom to use their own instance if needed.
Contribution Checklist
dotnet format