Move SK.CoreSkills to new package: SK.Skills.Core #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
|
Updating docs now... |
added 3 commits
June 20, 2023 19:23
5 tasks
lemillermicrosoft
previously approved these changes
Jun 21, 2023
Co-authored-by: Lee Miller <lemiller@microsoft.com>
…antic-kernel into core-skills-package
SergeyMenshykh
approved these changes
Jun 22, 2023
shawncal
added a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context Slimming down the kernel core project, nuget package. ### Description These "Core Skills" are good ones to have, but are not fundamental to the operation of SK. They will continue to be included in the "Microsoft.SemanticKernel" nuget metapackage, but if a developer chooses to just install the minimal "Microsoft.SemanticKernel.Core", they may not want these skills. This packages them so that they are now optional. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [X] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄 --------- Co-authored-by: name <email> Co-authored-by: Lee Miller <lemiller@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Slimming down the kernel core project, nuget package.
Description
These "Core Skills" are good ones to have, but are not fundamental to the operation of SK. They will continue to be included in the "Microsoft.SemanticKernel" nuget metapackage, but if a developer chooses to just install the minimal "Microsoft.SemanticKernel.Core", they may not want these skills. This packages them so that they are now optional.
Contribution Checklist
dotnet format