GitHub Actions: node-pr builds run in parallel #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawncal
force-pushed
the
node-pr-parallel
branch
from
0a507a7
to
bc966a0
Compare
alliscode
approved these changes
Jun 21, 2023
shawncal
added a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context node-pr builds take a very long time -- often around 11 min ### Description This runs all the sample app builds in parallel, completing in just under 4 minutes. See successful run in branch here: https://github.com/microsoft/semantic-kernel/actions/runs/5330432422 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] I didn't break anyone 馃槃
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context node-pr builds take a very long time -- often around 11 min ### Description This runs all the sample app builds in parallel, completing in just under 4 minutes. See successful run in branch here: https://github.com/microsoft/semantic-kernel/actions/runs/5330432422 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] I didn't break anyone 馃槃
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context node-pr builds take a very long time -- often around 11 min ### Description This runs all the sample app builds in parallel, completing in just under 4 minutes. See successful run in branch here: https://github.com/microsoft/semantic-kernel/actions/runs/5330432422 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] I didn't break anyone 馃槃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
node-pr builds take a very long time -- often around 11 min
Description
This runs all the sample app builds in parallel, completing in just under 4 minutes.
See successful run in branch here:
https://github.com/microsoft/semantic-kernel/actions/runs/5330432422
Contribution Checklist