Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: node-pr builds run in parallel #1626

Merged
merged 29 commits into from
Jun 21, 2023
Merged

Conversation

shawncal
Copy link
Member

@shawncal shawncal commented Jun 21, 2023

Motivation and Context

node-pr builds take a very long time -- often around 11 min

Description

This runs all the sample app builds in parallel, completing in just under 4 minutes.

See successful run in branch here:
https://github.com/microsoft/semantic-kernel/actions/runs/5330432422

Contribution Checklist

@shawncal shawncal added this pull request to the merge queue Jun 21, 2023
Merged via the queue into main with commit 2b29c8e Jun 21, 2023
5 checks passed
@shawncal shawncal deleted the node-pr-parallel branch June 21, 2023 16:39
@evchaki evchaki added this to the Sprint 34 milestone Jun 30, 2023
shawncal added a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
### Motivation and Context
node-pr builds take a very long time -- often around 11 min


### Description
This runs all the sample app builds in parallel, completing in just
under 4 minutes.

See successful run in branch here: 
https://github.com/microsoft/semantic-kernel/actions/runs/5330432422


### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [X] The code builds clean without any errors or warnings
- [X] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] I didn't break anyone 馃槃
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
### Motivation and Context
node-pr builds take a very long time -- often around 11 min


### Description
This runs all the sample app builds in parallel, completing in just
under 4 minutes.

See successful run in branch here: 
https://github.com/microsoft/semantic-kernel/actions/runs/5330432422


### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [X] The code builds clean without any errors or warnings
- [X] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] I didn't break anyone 馃槃
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
### Motivation and Context
node-pr builds take a very long time -- often around 11 min


### Description
This runs all the sample app builds in parallel, completing in just
under 4 minutes.

See successful run in branch here: 
https://github.com/microsoft/semantic-kernel/actions/runs/5330432422


### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [X] The code builds clean without any errors or warnings
- [X] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] I didn't break anyone 馃槃
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants