Add option to deserialize plan without requiring functions #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
lemillermicrosoft
added
the
PR: in progress
lemillermicrosoft
force-pushed
the
621_plan_functions
branch
from
f81d3c3
to
0c7548c
Compare
shawncal
force-pushed
the
621_plan_functions
branch
from
0c7548c
to
b34f2c8
Compare
shawncal
approved these changes
Jun 22, 2023
This commit adds a new parameter to the Plan.FromJson method that allows deserializing a plan from JSON without requiring the functions to be registered in the skill collection. This can be useful for scenarios where the plan is only used for inspection or analysis, and not for execution. The default behavior is still to require the functions, and an exception is thrown if a function is not found. The commit also adds unit tests for both cases, using the [Theory]/[InlineData] attributes to test different values of the parameter. The tests check that the deserialized plan has the same properties as the original plan, and that the exception is thrown when expected.
shawncal
force-pushed
the
621_plan_functions
branch
from
b34f2c8
to
6d5cee4
Compare
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…#1652) This commit adds a new parameter to the Plan.FromJson method that allows deserializing a plan without requiring the functions to be registered in the skill collection. This is useful for scenarios where the plan is only used for inspection or analysis, and not for execution. The default behavior is still to require the functions, and throw an exception if they are not found. The commit also adds unit tests for both cases, and updates the JSON serialization options to ignore default values. Resolves microsoft#1631 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new parameter to the Plan.FromJson method that allows deserializing a plan without requiring the functions to be registered in the skill collection. This is useful for scenarios where the plan is only used for inspection or analysis, and not for execution. The default behavior is still to require the functions, and throw an exception if they are not found. The commit also adds unit tests for both cases, and updates the JSON serialization options to ignore default values.
Resolves #1631
Contribution Checklist
dotnet format