Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/notebook bing search #1729

Merged
merged 20 commits into from
Jul 5, 2023
Merged

Feature/notebook bing search #1729

merged 20 commits into from
Jul 5, 2023

Conversation

N-E-W-T-O-N
Copy link
Contributor

@N-E-W-T-O-N N-E-W-T-O-N commented Jun 27, 2023 •
edited
Loading

Motivation and Context

Description

I have added a new notebook to show how to bring search functionality in SK

Contribution Checklist

@N-E-W-T-O-N N-E-W-T-O-N requested a review from a team as a code owner June 27, 2023 10:12
@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code samples labels Jun 27, 2023
gitri-ms
gitri-ms requested changes Jun 28, 2023
View reviewed changes
samples/notebooks/dotnet/09-BingSearch-using-kernel-prince.ipynb Outdated Show resolved Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel-prince.ipynb Outdated Show resolved Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel-prince.ipynb Outdated Show resolved Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel-prince.ipynb Outdated Show resolved Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel-prince.ipynb Outdated Show resolved Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel-prince.ipynb Outdated Show resolved Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel-prince.ipynb Outdated Show resolved Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel-prince.ipynb Outdated Show resolved Hide resolved
@gitri-ms gitri-ms added the PR: feedback to address Waiting for PR owner to address comments/questions label Jun 28, 2023
@N-E-W-T-O-N
Copy link
Contributor Author

@microsoft-github-policy-service agree

@N-E-W-T-O-N
Copy link
Contributor Author

Make tweaks as asked. @gitri-ms let me know is any more amends have to be make.

@N-E-W-T-O-N N-E-W-T-O-N requested a review from gitri-ms July 3, 2023 17:40
gitri-ms
gitri-ms requested changes Jul 3, 2023
View reviewed changes
samples/notebooks/dotnet/09-BingSearch-using-kernel.ipynb Outdated Show resolved Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel.ipynb Outdated Show resolved Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel.ipynb Outdated Show resolved Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel.ipynb Outdated Show resolved Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel.ipynb Outdated Show resolved Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel.ipynb Outdated Show resolved Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel.ipynb Outdated Show resolved Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel.ipynb Outdated Show resolved Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel.ipynb Outdated Show resolved Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel.ipynb Outdated Show resolved Hide resolved
@gitri-ms
Copy link
Contributor

gitri-ms commented Jul 3, 2023

Hi @N-E-W-T-O-N -- thanks for the updates! I did another review pass, it's looking pretty good but a few more things to address. I also need to do a full test pass on all the notebooks to make sure the version upgrade doesn't break anything before I can merge this in -- will get that done today. Thanks for all your work, and looking forward to bringing this change in!

@github-actions github-actions bot removed the .NET Issue or Pull requests regarding .NET code label Jul 4, 2023
@N-E-W-T-O-N
Copy link
Contributor Author

Updated the branch.
Please check it now.

@N-E-W-T-O-N N-E-W-T-O-N requested a review from gitri-ms July 4, 2023 19:14
@gitri-ms gitri-ms added PR: ready to merge PR has been approved by all reviewers, and is ready to merge. and removed PR: feedback to address Waiting for PR owner to address comments/questions labels Jul 5, 2023
@gitri-ms gitri-ms added this pull request to the merge queue Jul 5, 2023
@gitri-ms
Copy link
Contributor

gitri-ms commented Jul 5, 2023

Thanks @N-E-W-T-O-N for your contribution to our samples!

Merged via the queue into microsoft:main with commit 451b640 Jul 5, 2023
5 checks passed
@N-E-W-T-O-N N-E-W-T-O-N deleted the feature/notebook_bing_search branch July 6, 2023 03:48
@N-E-W-T-O-N
Copy link
Contributor Author

Thank you @gitri-ms to be patience withme .This is my first ever contribution in a big project.

shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
@N-E-W-T-O-N @gitri-ms
Feature/notebook bing search (microsoft#1729)
3bebad9 
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->


### Description
I have added a new notebook to show how to bring search functionality in
SK


### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: newton.mallick <newton.mallick@celebaltech.com>
Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com>
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
@N-E-W-T-O-N @gitri-ms
Feature/notebook bing search (microsoft#1729)
18e6ced 
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->


### Description
I have added a new notebook to show how to bring search functionality in
SK


### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: newton.mallick <newton.mallick@celebaltech.com>
Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com>
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
@N-E-W-T-O-N @gitri-ms
Feature/notebook bing search (microsoft#1729)
5a017ba 
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->


### Description
I have added a new notebook to show how to bring search functionality in
SK


### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: newton.mallick <newton.mallick@celebaltech.com>
Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitri-ms gitri-ms gitri-ms approved these changes

Assignees

@gitri-ms gitri-ms

Labels
PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
No open projects
Apps & Services Semantic Kernel
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@N-E-W-T-O-N @gitri-ms