Fixes for OpenApiSkillsExample #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitri-ms
added
PR: ready for review
dmytrostruk
approved these changes
Jun 28, 2023
dmytrostruk
added
the
PR: ready to merge
alliscode
approved these changes
Jun 28, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Fix for issue microsoft#1336 - When the token limit is exceeded, we unintentionally remove the system prompt from the chat history in order to remain under the token limit. Also addresses a couple other small issues with this sample. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> - Remove chat history items beginning with index 1, so that the system prompt (index 0) remains in the chat history. - Fix a naming mismatch in the configuration - the code looks for `TokenLimit` not `CompletionTokenLimit` - Add `UserSecretsId` property to the csproj file so users won't need to run `dotnet user-secrets init` themselves. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 馃槃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix for issue #1336 - When the token limit is exceeded, we unintentionally remove the system prompt from the chat history in order to remain under the token limit. Also addresses a couple other small issues with this sample.
Description
TokenLimitnotCompletionTokenLimitUserSecretsIdproperty to the csproj file so users won't need to rundotnet user-secrets initthemselves.Contribution Checklist
dotnet format