Fix SKFunction.InvokeAsync to respect input when passed in explicitly.
#1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
danpere
reviewed
Jun 28, 2023
dotnet/src/SemanticKernel/SkillDefinition/SKFunctionExtensions.cs
Outdated
Show resolved
Hide resolved
|
@shawncal, @dluc, what are the scenarios for having this mutableContext parameter at all? I agree with @NTaylorMullen this is a pit of failure. In general these SKContexts are mutable... if for a given call someone wants to instead clone it and operate on a clone, why not just have them do exactly that, i.e. pass in |
stephentoub
previously approved these changes
Jun 28, 2023
- The defaults for `mutableContext` are `true` which make it super easy to fall into this trap. I slammed my head against the wall for a while until realizing that the SK InvokeAsync method wasn't properly utilizing the `input` parameter.
|
@stephentoub, @NTaylorMullen Agreed, we need to drop this function. Partial fix was checked in with PR: |
shawncal
approved these changes
Jun 29, 2023
shawncal
added a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…ly. (microsoft#1757) - The defaults for `mutableContext` are `true` which make it super easy to fall into this trap. I slammed my head against the wall for a while until realizing that the SK InvokeAsync method wasn't properly utilizing the `input` parameter. --------- Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mutableContextaretruewhich make it super easy to fall into this trap. I slammed my head against the wall for a while until realizing that the SK InvokeAsync method wasn't properly utilizing theinputparameter.