Copilot Chat: Adding missing appsettings chatparticipant config to bicep template #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glahaye
reviewed
Jun 29, 2023
glahaye
approved these changes
Jun 29, 2023
shawncal
force-pushed
the
bicep-chat-participant
branch
from
8f9db13
to
f5862ff
Compare
shawncal
changed the title
gitri-ms
reviewed
Jun 29, 2023
teresaqhoang
added
the
PR: ready to merge
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…cep template (microsoft#1780) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Adding `ChatStore:Cosmos:ChatParticipantsContainer` config setting to the bicep template for the web app. In response to: https://github.com/orgs/microsoft/projects/852/views/5?pane=issue&itemId=32088282 Did a test deployment and verified that new setting is in the config! { "name": "ChatStore:Cosmos:ChatParticipantsContainer", "value": "chatparticipants", "slotSetting": false },  Then tested deployed webapi with local webapp instance and chatbot is running as expected ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
…cep template (microsoft#1780) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Adding `ChatStore:Cosmos:ChatParticipantsContainer` config setting to the bicep template for the web app. In response to: https://github.com/orgs/microsoft/projects/852/views/5?pane=issue&itemId=32088282 Did a test deployment and verified that new setting is in the config! { "name": "ChatStore:Cosmos:ChatParticipantsContainer", "value": "chatparticipants", "slotSetting": false },  Then tested deployed webapi with local webapp instance and chatbot is running as expected ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Adding
ChatStore:Cosmos:ChatParticipantsContainerconfig setting to the bicep template for the web app.In response to: https://github.com/orgs/microsoft/projects/852/views/5?pane=issue&itemId=32088282
Did a test deployment and verified that new setting is in the config!
{
},
Then tested deployed webapi with local webapp instance and chatbot is running as expected
Contribution Checklist
dotnet format