Chroma - fix for saving same memory record multiple times #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
dmytrostruk
added
memory connector
ai connector
dmytrostruk
changed the title
shawncal
approved these changes
Jun 30, 2023
glahaye
approved these changes
Jun 30, 2023
|
Should fix #1783 - Thanks! |
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…1790) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Method `SaveInformationAsync` of kernel memory type should be idempotent to update memory record with same key multiple times. This PR contains changes to allow that behavior in Chroma connector and tests to verify it. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> 1. Replaced Chroma `POST /collections/{collection_id}/add` with `POST collections/{collection_id}/upsert` to allow idempotent behavior. 2. Added integration tests to verify scenario with adding/updating memory record with same key multiple times. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Method
SaveInformationAsyncof kernel memory type should be idempotent to update memory record with same key multiple times. This PR contains changes to allow that behavior in Chroma connector and tests to verify it.Description
POST /collections/{collection_id}/addwithPOST collections/{collection_id}/upsertto allow idempotent behavior.Contribution Checklist
dotnet formatFixes #1783