Add JsonPathSkill #181
Merged
Add JsonPathSkill #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature openapi
shawncal
reviewed
Mar 28, 2023
dotnet/src/SemanticKernel.Skills/Skills.OpenAPI/JsonPathSkill.cs
Outdated
Show resolved
Hide resolved
|
seems odd that we have rely to newtonsoft for something that we'll want soon in the core of the kernel |
dmytrostruk
reviewed
Mar 28, 2023
dotnet/src/SemanticKernel.Skills/Skills.UnitTests/OpenAPI/JsonPathSkillTests.cs
Show resolved
Hide resolved
adrianwyatt
added
the
PR: ready for review
adrianwyatt
added
PR: feedback to address
adrianwyatt
added
PR: ready to merge
shawncal
approved these changes
Mar 28, 2023
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context Add JsonPathSkill for parsing results from OpenAPI calls. ### Description Simple JsonPath skill with a single SK function. The function supports returning a single value as plaintext, or anything else is returned as reserialized JSON, just as JArrays and JObjects. I used Newtonsoft.Json for JsonPath parsing since System.Text.Json does *not* support JsonPath. In the future we could move this into the core skills of the kernel if we write out own JsonPath parser or use a future System.Text.Json.
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context <!-- Thank you for your contribution to the copilot-chat repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Found copy & paste errors in our deployment scripts usage descriptions. They don't match the actual options. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Clean the usage descriptions for the deployment scripts. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Bryan-Roe
added a commit
to BMR-Cloud-Dev/semantic
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add JsonPathSkill for parsing results from OpenAPI calls.
Description
Simple JsonPath skill with a single SK function. The function supports returning a single value as plaintext, or anything else is returned as reserialized JSON, just as JArrays and JObjects.
I used Newtonsoft.Json for JsonPath parsing since System.Text.Json does not support JsonPath. In the future we could move this into the core skills of the kernel if we write out own JsonPath parser or use a future System.Text.Json.