Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Add Logit-Bias to TextCompletion abstractions #1880

Merged
merged 73 commits into from Jul 14, 2023

Conversation

SebasX5
Copy link
Contributor

@SebasX5 SebasX5 commented Jul 6, 2023

Motivation and Context

  1. Adds the Logit-Bias feature that is in the C# into Python.
  2. It adds the token bias configuration to the text and chat completion settings.
  3. It contributes to flexibility in prompt engineering by allowing the user to influence the likelihood of specified tokens appearing in the text and chat completion.
  4. Closes Python: Add Logic-Bias and any potential property missing to TextCompletion abstractions. #1854

Description

We added a dictionary field called token_selection_biases to the classes CompleteRequestSettings and ChatRequestSettings to implement logit bias and included an example to demonstrate functionality.

Contribution Checklist

@github-actions github-actions bot added the python Pull requests for the Python Semantic Kernel label Jul 6, 2023
@SebasX5
Copy link
Contributor Author

SebasX5 commented Jul 6, 2023

@SebasX5 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@awharrison-28 awharrison-28 self-assigned this Jul 11, 2023
@awharrison-28 awharrison-28 added PR: ready for review All feedback addressed, ready for reviews and removed PR: feedback to address Waiting for PR owner to address comments/questions labels Jul 12, 2023
alexchaomander
alexchaomander previously approved these changes Jul 13, 2023
Copy link
Contributor

@alexchaomander alexchaomander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great example. Left one comment to consider

python/samples/kernel-syntax-examples/logit_bias.py Outdated Show resolved Hide resolved
@awharrison-28 awharrison-28 added this pull request to the merge queue Jul 14, 2023
Merged via the queue into microsoft:main with commit 378a1a9 Jul 14, 2023
20 checks passed
piotrek-appstream pushed a commit to Appstream-Studio/semantic-kernel that referenced this pull request Jul 19, 2023
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
1. Adds the Logit-Bias feature that is in the C# into Python.
2. It adds the token bias configuration to the text and chat completion
settings.
3. It contributes to flexibility in prompt engineering by allowing the
user to influence the likelihood of specified tokens appearing in the
text and chat completion.
4. Closes microsoft#1854 

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
We added a dictionary field called token_selection_biases to the classes
CompleteRequestSettings and ChatRequestSettings to implement logit bias
and included an example to demonstrate functionality.
### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [X] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [x] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄

---------

Co-authored-by: sneha <de_sneha@outlook.com>
Co-authored-by: Alisha Maddy <59581465+am831@users.noreply.github.com>
Co-authored-by: Alisha Maddy <alisha831maddy@gmail.com>
Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
Co-authored-by: Sneha <55897319+sneha-afk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready for review All feedback addressed, ready for reviews python Pull requests for the Python Semantic Kernel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Python: Add Logic-Bias and any potential property missing to TextCompletion abstractions.
5 participants