New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Add Logit-Bias to TextCompletion abstractions #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into issue1854
…into issue1854
…into issue1854
@microsoft-github-policy-service agree |
…into issue1854
…into issue1854
…into issue1854
awharrison-28
added
PR: ready for review
All feedback addressed, ready for reviews
and removed
PR: feedback to address
Waiting for PR owner to address comments/questions
labels
Jul 12, 2023
alexchaomander
previously approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Great example. Left one comment to consider
awharrison-28
approved these changes
Jul 13, 2023
piotrek-appstream
pushed a commit
to Appstream-Studio/semantic-kernel
that referenced
this pull request
Jul 19, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> 1. Adds the Logit-Bias feature that is in the C# into Python. 2. It adds the token bias configuration to the text and chat completion settings. 3. It contributes to flexibility in prompt engineering by allowing the user to influence the likelihood of specified tokens appearing in the text and chat completion. 4. Closes microsoft#1854 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> We added a dictionary field called token_selection_biases to the classes CompleteRequestSettings and ChatRequestSettings to implement logit bias and included an example to demonstrate functionality. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄 --------- Co-authored-by: sneha <de_sneha@outlook.com> Co-authored-by: Alisha Maddy <59581465+am831@users.noreply.github.com> Co-authored-by: Alisha Maddy <alisha831maddy@gmail.com> Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com> Co-authored-by: Sneha <55897319+sneha-afk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: ready for review
All feedback addressed, ready for reviews
python
Pull requests for the Python Semantic Kernel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
We added a dictionary field called token_selection_biases to the classes CompleteRequestSettings and ChatRequestSettings to implement logit bias and included an example to demonstrate functionality.
Contribution Checklist
dotnet format