Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating dotnet samples to 17.230704.3 #1886

Merged
merged 9 commits into from
Jul 10, 2023
Merged

Updating dotnet samples to 17.230704.3 #1886

merged 9 commits into from
Jul 10, 2023

Conversation

shawncal
Copy link
Member

@shawncal shawncal commented Jul 7, 2023 •
edited
Loading

Also included:

  • Removing FileCompression project
    • no longer used
  • Merging GitHubSkill into KernelHttpServer
    • rename to GitHubPlugin (...the first of many to receive such treatment)
    • this is where it's used, and it will allow us to instantiate the github skill without passing the access token as a context variable (this change not yet implemented).
  • Removing LoadPromptsFromCloud
    • we are moving to a "plugin-first" approach - loading plugins, not raw prompts. This approach is no longer recommended.

Resolves #1876

@shawncal shawncal requested review from a team as code owners July 7, 2023 02:48
@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code samples labels Jul 7, 2023
dmytrostruk
dmytrostruk previously approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@dmytrostruk dmytrostruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmytrostruk dmytrostruk added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label Jul 7, 2023
@gitri-ms gitri-ms self-assigned this Jul 7, 2023
@github-actions github-actions bot added the docs and tests Improvements or additions to documentation label Jul 7, 2023
@gitri-ms gitri-ms added this pull request to the merge queue Jul 10, 2023
Merged via the queue into microsoft:main with commit 7880407 Jul 10, 2023
16 checks passed
@shawncal shawncal deleted the update-samples-17-230704 branch July 27, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitri-ms gitri-ms gitri-ms approved these changes

@dmytrostruk dmytrostruk dmytrostruk left review comments

@mkarle mkarle Awaiting requested review from mkarle

@TaoChenOSU TaoChenOSU Awaiting requested review from TaoChenOSU

@awharrison-28 awharrison-28 Awaiting requested review from awharrison-28

@adrianwyatt adrianwyatt Awaiting requested review from adrianwyatt

@teresaqhoang teresaqhoang Awaiting requested review from teresaqhoang

Assignees

@gitri-ms gitri-ms

Labels
docs and tests Improvements or additions to documentation .NET Issue or Pull requests regarding .NET code PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sample apps depend on outdated Semantic Kernel
3 participants
@shawncal @dmytrostruk @gitri-ms