.Net: Ensure Action is JSON format in Stepwise Planner #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawncal
added
.NET
shawncal
changed the title
|
Here's an example of the Planner messing up on the [ACTION] 
|
shawncal
approved these changes
Jul 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dmytrostruk
approved these changes
Jul 17, 2023
dmytrostruk
added
the
PR: ready to merge
shawncal
approved these changes
Jul 17, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
piotrek-appstream
pushed a commit
to Appstream-Studio/semantic-kernel
that referenced
this pull request
Jul 19, 2023
### Motivation and Context Sometimes, the LLM populates the [ACTION] with non-JSON data. To mitigate this from happening, this PR updates the labels for the [ACTION] section of the prompt to more explicitly state that **_only_** JSON should be written there. ### Description - [ACTION] has been changed to [JSON ACTION] in the prompt to make it clear that JSON should appear in this section. - $JSON_BLOB has been changed to $JSON_ACTION to make it more clear that the instructions above are for the [JSON ACTION] section ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com> Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Sometimes, the LLM populates the [ACTION] with non-JSON data. To mitigate this from happening, this PR updates the labels for the [ACTION] section of the prompt to more explicitly state that only JSON should be written there.
Description
Contribution Checklist
dotnet format