Python: Default logit-bias {} instead of None #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… demonstrated to be flaky resulting in responses of Service Error and Forbidden
…ious versions, add additional psycop dependencies to be usable on more systems, fix chroma dependency issue with newer versions
…/microsoft/semantic-kernel into feature-python-integration-tests
…/microsoft/semantic-kernel into feature-python-integration-tests
alexchaomander
approved these changes
Jul 15, 2023
piotrek-appstream
pushed a commit
to Appstream-Studio/semantic-kernel
that referenced
this pull request
Jul 19, 2023
### Motivation and Context
The openai API expects that logit bias is always a set. Passing None
will not be successful.
### Description
- if logit-bias is None, pass {} to the openai request create call
### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#dev-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
---------
Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The openai API expects that logit bias is always a set. Passing None will not be successful.
Description
Contribution Checklist