Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Samples causing error: PlanningException: Create plan err #2018

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

Escoto
Copy link
Contributor

@Escoto Escoto commented Jul 17, 2023

Motivation and Context

I am testing the Samples. I was getting this error:

Error: Microsoft.SemanticKernel.Planning.PlanningException: Create plan error: Unable to create plan
---> Microsoft.SemanticKernel.Planning.PlanningException: Invalid plan: Failed to find function 'WriterSkill.Shakespeare' in skill 'WriterSkill'.
at Microsoft.SemanticKernel.Planning.Sequential.SequentialPlanParser.ToPlanFromXml(String xmlString, String goal, SKContext context, Boolean allowMissingFunctions)
at Microsoft.SemanticKernel.Planning.SequentialPlanner.CreatePlanAsync(String goal)
--- End of inner exception stack trace ---
at Microsoft.SemanticKernel.Planning.SequentialPlanner.CreatePlanAsync(String goal)
at Submission#10.<<Initialize>>d__0.MoveNext()
--- End of stack trace from previous location ---
at Microsoft.CodeAnalysis.Scripting.ScriptExecutionState.RunSubmissionsAsync[TResult](ImmutableArray`1 precedingExecutors, Func`2 currentExecutor, StrongBox`1 exceptionHolderOpt, Func`2 catchExceptionOpt, CancellationToken cancellationToken)

After fixing the function name, the sample worked as expected.

Description

Error when trying to run sample 05-using-the-planner.ipynb

Contribution Checklist

@Escoto Escoto requested a review from a team as a code owner July 17, 2023 14:20
@shawncal shawncal enabled auto-merge July 17, 2023 16:43
@shawncal shawncal added this pull request to the merge queue Jul 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2023
@shawncal shawncal added this pull request to the merge queue Jul 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2023
@shawncal
Copy link
Member

@Escoto sorry for the noise. This keeps getting booted due to an unrelated integration test failure. I've reverted an earlier change, and requeued this one. Fingers crossed...

@shawncal shawncal added this pull request to the merge queue Jul 17, 2023
Merged via the queue into microsoft:main with commit 5721ac4 Jul 17, 2023
6 checks passed
piotrek-appstream pushed a commit to Appstream-Studio/semantic-kernel that referenced this pull request Jul 19, 2023
…microsoft#2018)

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

I am testing the Samples. I was getting this error:

```
Error: Microsoft.SemanticKernel.Planning.PlanningException: Create plan error: Unable to create plan
---> Microsoft.SemanticKernel.Planning.PlanningException: Invalid plan: Failed to find function 'WriterSkill.Shakespeare' in skill 'WriterSkill'.
at Microsoft.SemanticKernel.Planning.Sequential.SequentialPlanParser.ToPlanFromXml(String xmlString, String goal, SKContext context, Boolean allowMissingFunctions)
at Microsoft.SemanticKernel.Planning.SequentialPlanner.CreatePlanAsync(String goal)
--- End of inner exception stack trace ---
at Microsoft.SemanticKernel.Planning.SequentialPlanner.CreatePlanAsync(String goal)
at Submission#10.<<Initialize>>d__0.MoveNext()
--- End of stack trace from previous location ---
at Microsoft.CodeAnalysis.Scripting.ScriptExecutionState.RunSubmissionsAsync[TResult](ImmutableArray`1 precedingExecutors, Func`2 currentExecutor, StrongBox`1 exceptionHolderOpt, Func`2 catchExceptionOpt, CancellationToken cancellationToken)
```

After fixing the function name, the sample worked as expected.


### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

Error when trying to run sample `05-using-the-planner.ipynb`


### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#dev-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

Co-authored-by: Rafael Escoto <ra.escoto@slalom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants