-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: make input parameter optional #2234
Python: make input parameter optional #2234
Conversation
@mkarle Can you review please? |
I ran unit and integration tests as well as some samples and notebooks and didn't notice any regression. |
@joowon-dm-snu: Your branch is locked, so we cannot rebase and merge. The failing tests you're seeing above are not related to your change -- if you grant repo admins permissions to change your PR branch, we can update and merge the PR. Thanks! ![]() |
@shawncal The organization repo doesn't allow selecting the "Allow edits from maintainers" option. I've already made three PRs in that repo, so is it okay if I temporarily invite two people(@mkarle, @awharrison-28) to the From now on, I'll probably proceed with my personal account. |
@shawncal |
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> solve microsoft#2233 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 馃槃 Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
Motivation and Context
solve #2233
Description
Contribution Checklist