.Net: Update samples to use SK 0.18 #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawncal
added
docs and tests
shawncal
changed the title
glahaye
added
PR: ready for review
shawncal
added
docs and tests
|
#2207 ?? |
shawncal
requested changes
Aug 1, 2023
Argh. I just compared our branches. There are a couple of differences. Maybe merge one in then update the other to see what's missing? Actually, my changes encompass all of yours except for the addition of "Memory = kernel.Memory" at line 133 of Is that addition needed since that example doesn't seem to use memory to recall functions? Other than that, the changes in this PR include some that I believe should have been made in your branch too. I suggest merging this PR. Then, when you synch yours to main, there should be nothing left to merge from your side (except maybe the "Memory = kernel.Memory" mentioned above). |
shawncal
approved these changes
Aug 2, 2023
mkarle
pushed a commit
to mkarle/semantic-kernel
that referenced
this pull request
Aug 2, 2023
### Motivation and Context Time marches on, ### Description Updated samples to use SK 0.18 and modified code when necessary due to that upgrade. ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
### Motivation and Context Time marches on, ### Description Updated samples to use SK 0.18 and modified code when necessary due to that upgrade. ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Time marches on,
Description
Updated samples to use SK 0.18 and modified code when necessary due to that upgrade.
Contribution Checklist