Python: Fix Integration Tests, Send Push Notifications to Teams, Add Merge Gate #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntial planner test
…database is not working well on windows
shawncal
added
python
awharrison-28
force-pushed
the
feature-python-integration-tests
branch
from
51e90ae
to
cf1d92d
Compare
dmytrostruk
approved these changes
Aug 2, 2023
python/semantic_kernel/connectors/memory/qdrant/qdrant_memory_store.py
Outdated
Show resolved
Hide resolved
…store.py Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
mkarle
pushed a commit
to mkarle/semantic-kernel
that referenced
this pull request
Aug 2, 2023
…Merge Gate (microsoft#2279) This PR addresses multiple issues with the integration tests. Fixes integration test breaks related to qdrant and chroma package updates. Labels known flaky tests as xfail. Adds merge queue gates. Adds push notifications to teams for test results. - integration tests are now 1x daily down from 2x daily - adds a run condition for `merge_group` - if run for merge_group, a subset of the tests will gate the merge - ends the results of each test matrix to a dedicated teams channel - update qdrant client requirement in the pyproject.toml - remove `persist_directory` from chroma, as the default is now persistent - default with_embedding to false in qdrant_memory_store - modify chroma test setup and teardown to create the database in a known location and clear the database of entries at the end of each test (I would have just deleted the database at the end of each test, but there are test agent permissions issues with this in CI) - marked known flaky tests (pinecone and sequential_planner) as allowed to fail Fixes microsoft#2284 --------- Co-authored-by: Abby Harrison <abharris@microsoft.com> Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
…Merge Gate (microsoft#2279) ### Motivation and Context This PR addresses multiple issues with the integration tests. Fixes integration test breaks related to qdrant and chroma package updates. Labels known flaky tests as xfail. Adds merge queue gates. Adds push notifications to teams for test results. ### Description - integration tests are now 1x daily down from 2x daily - adds a run condition for `merge_group` - if run for merge_group, a subset of the tests will gate the merge - ends the results of each test matrix to a dedicated teams channel - update qdrant client requirement in the pyproject.toml - remove `persist_directory` from chroma, as the default is now persistent - default with_embedding to false in qdrant_memory_store - modify chroma test setup and teardown to create the database in a known location and clear the database of entries at the end of each test (I would have just deleted the database at the end of each test, but there are test agent permissions issues with this in CI) - marked known flaky tests (pinecone and sequential_planner) as allowed to fail Fixes microsoft#2284 --------- Co-authored-by: Abby Harrison <abharris@microsoft.com> Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR addresses multiple issues with the integration tests. Fixes integration test breaks related to qdrant and chroma package updates. Labels known flaky tests as xfail. Adds merge queue gates. Adds push notifications to teams for test results.
Description
merge_grouppersist_directoryfrom chroma, as the default is now persistentFixes #2284