Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Serialization add pydantic integration instructions #2288

Conversation

AdityaGudimella
Copy link
Contributor

Summary

This is part 1 of the Serialization work for semantic kernel.

Corresponding issue: #131

Motivation and Context

Adds instructions on how to serialize your classes using Pydantic.

Description

Contribution Checklist

@AdityaGudimella AdityaGudimella requested a review from a team as a code owner August 2, 2023 19:21
@shawncal shawncal added docs and tests Improvements or additions to documentation python Pull requests for the Python Semantic Kernel labels Aug 2, 2023
@shawncal shawncal changed the title Serialization add pydantic integration instructions Python: Serialization add pydantic integration instructions Aug 2, 2023
python/DEV_SETUP.md Outdated Show resolved Hide resolved
Copy link
Contributor

@awharrison-28 awharrison-28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small suggestion, other than that, LGTM

awharrison-28 and others added 2 commits August 4, 2023 10:55
Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
@awharrison-28 awharrison-28 added this pull request to the merge queue Aug 4, 2023
Merged via the queue into microsoft:main with commit 68dbbcf Aug 4, 2023
27 checks passed
SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request Nov 1, 2023
…t#2288)

### Summary

This is part 1 of the Serialization work for semantic kernel.

Corresponding issue:
microsoft#131

### Motivation and Context

Adds instructions on how to serialize your classes using Pydantic.


<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs and tests Improvements or additions to documentation python Pull requests for the Python Semantic Kernel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants