-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Serialization add pydantic integration instructions #2288
Merged
awharrison-28
merged 4 commits into
microsoft:main
from
AdityaGudimella:Serialization-Add-Pydantic-integration-instructions
Aug 4, 2023
Merged
Python: Serialization add pydantic integration instructions #2288
awharrison-28
merged 4 commits into
microsoft:main
from
AdityaGudimella:Serialization-Add-Pydantic-integration-instructions
Aug 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawncal
added
docs and tests
Improvements or additions to documentation
python
Pull requests for the Python Semantic Kernel
labels
Aug 2, 2023
shawncal
changed the title
Serialization add pydantic integration instructions
Python: Serialization add pydantic integration instructions
Aug 2, 2023
awharrison-28
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small suggestion, other than that, LGTM
mkarle
approved these changes
Aug 3, 2023
Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
awharrison-28
approved these changes
Aug 4, 2023
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
…t#2288) ### Summary This is part 1 of the Serialization work for semantic kernel. Corresponding issue: microsoft#131 ### Motivation and Context Adds instructions on how to serialize your classes using Pydantic. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs and tests
Improvements or additions to documentation
python
Pull requests for the Python Semantic Kernel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is part 1 of the Serialization work for semantic kernel.
Corresponding issue: #131
Motivation and Context
Adds instructions on how to serialize your classes using Pydantic.
Description
Contribution Checklist