Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InteractWithGraph.tsx - Fix failures caused by break change of stripping off the async suffix from SK functions #2483

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

freistli
Copy link
Contributor

Fix failures caused by break change of stripping off the async suffix from SK functions

Motivation and Context

The auth-api sample doesn't work anymore because of the break change listed in https://github.com/freistli/semantic-kernel/blob/main/docs/decisions/0003-support-multiple-native-function-args.md

Updated name selection heuristic to strip off an "Async" suffix for async methods.

Description

KernelServer service reports similar errors the sample is calling:

Result: Function 'InvokeFunction', Invocation id '6dcbc5af-9484-4357-a5ac-c91b585dfac5': An exception was thrown by the invocation.
Exception: System.AggregateException: One or more errors occurred. (Function not available: Function not available emailskill.getmyemailaddressasync)

Contribution Checklist

Fix failures caused by break change of stripping off the async suffix from SK functions
@freistli freistli requested a review from a team as a code owner August 17, 2023 10:16
@freistli freistli changed the title Update InteractWithGraph.tsx Update InteractWithGraph.tsx - Fix failures caused by break change of stripping off the async suffix from SK functions Aug 17, 2023
@nacharya1 nacharya1 assigned nacharya1 and unassigned nacharya1 Aug 18, 2023
@gitri-ms gitri-ms assigned teresaqhoang and unassigned gitri-ms Aug 21, 2023
@shawncal
Copy link
Member

@freistli We've fixed the failing precheck (Python Integration Tests) on our end, but we cannot update your branch or queue a new build. It looks like you have not yet checked the "Allow edits from maintainers" box that would normally show this on the righth column:
image

Could you please update (merge) the latest changes from main? And, if you see the option, check the "allow edits from maintainers" box in this PR? That will allow us to merge directly into main upon successful checks, or apply further merges if needed. Thanks!

@freistli
Copy link
Contributor Author

Thanks @shawncal , just merged the main branch in the pull request. I cannot see "allow edits from maintainers" option on my right column. Now the PR status is waiting for OCTO group reviewers' approval.

@shawncal shawncal added this pull request to the merge queue Aug 22, 2023
@shawncal
Copy link
Member

Awesome, queued for merge. Thanks @freistli for the fix!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 22, 2023
@shawncal shawncal added this pull request to the merge queue Aug 22, 2023
Merged via the queue into microsoft:main with commit 2b31629 Aug 22, 2023
19 checks passed
SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request Nov 1, 2023
… stripping off the async suffix from SK functions (microsoft#2483)

Fix failures caused by break change of stripping off the async suffix
from SK functions

### Motivation and Context

The auth-api sample doesn't work anymore because of the break change
listed in
https://github.com/freistli/semantic-kernel/blob/main/docs/decisions/0003-support-multiple-native-function-args.md

Updated name selection heuristic to strip off an "Async" suffix for
async methods.


### Description

KernelServer service reports similar errors the sample is calling:

Result: Function 'InvokeFunction', Invocation id
'6dcbc5af-9484-4357-a5ac-c91b585dfac5': An exception was thrown by the
invocation.
Exception: System.AggregateException: One or more errors occurred.
(Function not available: Function not available
emailskill.getmyemailaddressasync)

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants