-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: No more hardcoded Azure OpenAI Service deployment name #2684
Python: No more hardcoded Azure OpenAI Service deployment name #2684
Conversation
@microsoft-github-policy-service agree |
@awharrison-28 - can you take a look at this PR and provide some guidance on next steps. |
It would be great to get this merged as the samples do not work with Azure OpenAI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates!
…soft#2684) ### Motivation and Context Solve confusion due to hardcoded Azure OpenAI Service deployment name in Python notebooks. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description Previously, the deployment name for Azure OpenAI Service in the Python notebooks was hardcoded as "gpt-35-turbo". This PR solves the confusion by using the `deployment` variable loaded from `.env` file. <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Motivation and Context
Solve confusion due to hardcoded Azure OpenAI Service deployment name in Python notebooks.
Description
Previously, the deployment name for Azure OpenAI Service in the Python notebooks was hardcoded as "gpt-35-turbo".
This PR solves the confusion by using the
deployment
variable loaded from.env
file.Contribution Checklist