-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Fixes for Chroma connector to be compatible with Chroma 0.4.10 #2796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I still get this error downloading main It can write data into Chroma, and query them, looks like it fails to deserialize:
|
@jamescarter-le Thanks for reporting. As mentioned in notebook, current version of SK in notebook is compatible with Chroma version semantic-kernel/dotnet/samples/KernelSyntaxExamples/Example15_TextMemoryPlugin.cs Lines 54 to 55 in 11fdd43
|
Oh I see! The notebook is referencing a nuget package whilst the KernelSyntaxExamples reference the latest code and project. I was able to run the same by pulling 0.4.0 chroma, my fault for not reading the notebook thoroughly. Could change the chroma download instructions to include:
Appreciate the support and enjoying SK so far. |
…icrosoft#2796) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Resolves: microsoft#2790 This PR contains changes to update processing of boolean values in order to be compatible with Chroma 0.4.10. With new Chroma updates we need to update Chroma connector on regular basis to be compatible. The note has been added to Chroma notebook and README file to show the latest version of Chroma, which was used to verify the connector. In order to fix notebook to be compatible with latest version, the notebook should be updated as soon as this PR is released. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> 1. Removed `ChromaBooleanConverter` to be compatible with Chroma 0.4.10. 2. Added note with latest tested version of Chroma in notebook and README file. 3. Updated unit tests. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Motivation and Context
Resolves: #2790
This PR contains changes to update processing of boolean values in order to be compatible with Chroma 0.4.10.
With new Chroma updates we need to update Chroma connector on regular basis to be compatible.
The note has been added to Chroma notebook and README file to show the latest version of Chroma, which was used to verify the connector.
In order to fix notebook to be compatible with latest version, the notebook should be updated as soon as this PR is released.
Description
ChromaBooleanConverter
to be compatible with Chroma 0.4.10.Contribution Checklist