Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Fix XML escaping in skprompt.txt examples #2827

Merged

Conversation

lemillermicrosoft
Copy link
Member

@lemillermicrosoft lemillermicrosoft commented Sep 14, 2023

Update the examples in skprompt.txt to correctly escape XML characters and improve the clarity of the comments.

Fixes #2246

Contribution Checklist

Update the examples in skprompt.txt to correctly escape XML
characters and improve the clarity of the comments.
@lemillermicrosoft lemillermicrosoft requested a review from a team as a code owner September 14, 2023 20:22
@shawncal shawncal added the python Pull requests for the Python Semantic Kernel label Sep 14, 2023
@github-actions github-actions bot changed the title Fix XML escaping in skprompt.txt examples Python: Fix XML escaping in skprompt.txt examples Sep 14, 2023
This commit updates the skprompt.txt file to fix XML escaping and
comment handling in function examples. The changes include updating
the parameter value to properly escape a comment and replacing an
incorrect example with a valid one.
@lemillermicrosoft lemillermicrosoft requested a review from a team as a code owner September 14, 2023 22:16
@lemillermicrosoft lemillermicrosoft changed the title Python: Fix XML escaping in skprompt.txt examples Fix XML escaping in skprompt.txt examples Sep 14, 2023
@lemillermicrosoft lemillermicrosoft removed the python Pull requests for the Python Semantic Kernel label Sep 14, 2023
@shawncal shawncal added .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel kernel Issues or pull requests impacting the core kernel labels Sep 14, 2023
@github-actions github-actions bot changed the title Fix XML escaping in skprompt.txt examples Python: Fix XML escaping in skprompt.txt examples Sep 14, 2023
@github-actions github-actions bot changed the title Python: Fix XML escaping in skprompt.txt examples .Net: Fix XML escaping in skprompt.txt examples Sep 14, 2023
@lemillermicrosoft lemillermicrosoft added this pull request to the merge queue Sep 14, 2023
Merged via the queue into microsoft:main with commit 8fcd7c0 Sep 14, 2023
32 checks passed
@lemillermicrosoft lemillermicrosoft deleted the 914_sequential_quotes branch September 14, 2023 22:50
SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request Nov 1, 2023
Update the examples in skprompt.txt to correctly escape XML characters
and improve the clarity of the comments.

Fixes microsoft#2246

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 馃槃

---------

Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET Sequential Planner: Invalid plan XML caused by single quotes in function payload
2 participants