.Net: Adding IKernel property the SKContext - Phase 1 #2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerBarreto
added
PR: ready for review
github-actions
bot
changed the title
|
@RogerBarreto I would like to understand the rationale behind the change a little better. Did we have a technical discussion? If not, let's have one. |
shawncal
reviewed
Sep 15, 2023
shawncal
reviewed
Sep 15, 2023
shawncal
reviewed
Sep 15, 2023
dotnet/samples/KernelSyntaxExamples/Example05_InlineFunctionDefinition.cs
Outdated
Show resolved
Hide resolved
shawncal
reviewed
Sep 15, 2023
dotnet/samples/KernelSyntaxExamples/Example07_BingAndGoogleSkills.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Orchestration/SKContext.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Orchestration/SKContext.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Orchestration/SKContext.cs
Outdated
Show resolved
Hide resolved
…into features/skcontext-kernel
lemillermicrosoft
approved these changes
Sep 19, 2023
…nto features/skcontext-kernel
| @@ -93,7 +92,7 @@ public LanguageCalculatorPlugin(IKernel kernel) | |||
|
|
|||
| try | |||
| { | |||
| answer = await this._mathTranslator.InvokeAsync(input).ConfigureAwait(false); | |||
| answer = await context.Kernel.RunAsync(input).ConfigureAwait(false); | |||
There was a problem hiding this comment.
Whoops, I think this was wrong @RogerBarreto
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
### Motivation and Context⚠️ Breaking Change Adding Kernel instance as part of the SKContext enable functions to interact with other services available in the kernel from within the functions, including the ability to call other Functions using the same Kernel "context" as described in microsoft#2825 This will also allow Kernel.RunAsync to execute and trigger events (Resolves Partially microsoft#2324) seamlessly when running plans, plans steps and rendering prompts from templates (template engine) without resorting to implement those events for Plans and Template Engine separately. This change is also a step forward in making IKernel.RunAsync the main way to Invoke functions. ### Description This first step is only adding Kernel as a required SKContext property, PS: Other changes will start to harnessing the SKContext.Kernel reference to call Steps and Prompt rendering (thru prompt template engine) moving forward. ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Adding Kernel instance as part of the SKContext enable functions to interact with other services available in the kernel from within the functions, including the ability to call other Functions using the same Kernel "context" as described in #2825
This will also allow Kernel.RunAsync to execute and trigger events (Resolves Partially #2324) seamlessly when running plans, plans steps and rendering prompts from templates (template engine) without resorting to implement those events for Plans and Template Engine separately.
This change is also a step forward in making IKernel.RunAsync the main way to Invoke functions.
Description
This first step is only adding Kernel as a required SKContext property,
PS: Other changes will start to harnessing the SKContext.Kernel reference to call Steps and Prompt rendering (thru prompt template engine) moving forward.
Contribution Checklist