.Net: Making ContextVariables into a proper Dictionary. #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawncal
added
.NET
github-actions
bot
changed the title
dotnet/src/SemanticKernel.Abstractions/Orchestration/ContextVariables.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Orchestration/ContextVariables.cs
Show resolved
Hide resolved
RogerBarreto
requested changes
Sep 18, 2023
dotnet/src/SemanticKernel.Abstractions/Orchestration/ContextVariables.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Orchestration/ContextVariables.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Orchestration/ContextVariables.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Orchestration/ContextVariables.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Orchestration/ContextVariables.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.UnitTests/Orchestration/ContextVariablesTests.cs
Outdated
Show resolved
Hide resolved
hario90
approved these changes
Sep 18, 2023
shawncal
added
the
PR: breaking change
…awncal/semantic-kernel into context-vars-dictionary-sep15
shawncal
added
the
PR: ready for review
lemillermicrosoft
approved these changes
Sep 19, 2023
dotnet/src/Skills/Skills.UnitTests/MsGraph/CalendarSkillTests.cs
Outdated
Show resolved
Hide resolved
lemillermicrosoft
approved these changes
Sep 20, 2023
RogerBarreto
approved these changes
Sep 20, 2023
lemillermicrosoft
approved these changes
Sep 20, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
### Description Simplifying ContextVariables by making it into an actual Dictionary<string, string> instead of a reimplemenation. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 - BREAKING CHANGE - use normal Dictionary methods instead. Behavior change: retrieving missing values via indexer [key] will throw if argument is missing, instead of returning string.Empty. --------- Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplifying ContextVariables by making it into an actual Dictionary<string, string> instead of a reimplemenation.
Contribution Checklist