.Net: Removing IsSemantic and IsAsync properties from ISKFunction and FunctionView #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawncal
added
.NET
dotnet/src/SemanticKernel.Abstractions/SemanticFunctions/IPromptTemplate.cs
Outdated
Show resolved
Hide resolved
SergeyMenshykh
approved these changes
Sep 19, 2023
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
… FunctionView (microsoft#2881) ### Motivation and Context The Kernel no longer differentiates between Native and Semantic functions, nor between async and synchronous functions. These are abstractions that are resolved internally. ### Description ISKFunction - Removing IsSemantic - Updating tests and callers FunctionView - Removing IsSemantic - Removing IsAsync - Updating tests and callers ### Contribution Checklist - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 BREAKING CHANGE - due to change in public APIs. Low impact. --------- Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The Kernel no longer differentiates between Native and Semantic functions, nor between async and synchronous functions. These are abstractions that are resolved internally.
Description
ISKFunction
FunctionView
Contribution Checklist
BREAKING CHANGE - due to change in public APIs. Low impact.