.Net: Replace IPromptTemplateEngine with IPromptTemplateFactory Update prompt rendering and template engine in dotnet samples #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd_IPromptTemplateFactory
shawncal
added
docs and tests
github-actions
bot
changed the title
|
/sk generate-pr-description |
github-actions
bot
changed the title
|
Generate PR Description: succeeded ✅ |
…//github.com/markwallace-microsoft/semantic-kernel into users/markwallace/Add_IPromptTemplateFactory
dotnet/src/Extensions/TemplateEngine.Basic/BasicPromptTemplateFactory.cs
Outdated
Show resolved
Hide resolved
markwallace-microsoft
force-pushed
the
users/markwallace/Add_IPromptTemplateFactory
branch
from
92c4264
to
535ec57
Compare
RogerBarreto
requested changes
Oct 31, 2023
dotnet/src/SemanticKernel.Core/Extensions/KernelSemanticFunctionExtensions.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Core/Extensions/KernelSemanticFunctionExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Core/Extensions/KernelSemanticFunctionExtensions.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Core/Extensions/KernelSemanticFunctionExtensions.cs
Show resolved
Hide resolved
dotnet/samples/KernelSyntaxExamples/Example56_TemplateNativeFunctionsWithMultipleArguments.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Extensions/Extensions.UnitTests/TemplateEngine/Prompt/PromptTemplateEngineTests.cs
Show resolved
Hide resolved
…//github.com/markwallace-microsoft/semantic-kernel into users/markwallace/Add_IPromptTemplateFactory
RogerBarreto
approved these changes
Nov 1, 2023
markwallace-microsoft
force-pushed
the
users/markwallace/Add_IPromptTemplateFactory
branch
from
1239cd1
to
60aeca9
Compare
RogerBarreto
requested changes
Nov 6, 2023
dotnet/src/SemanticKernel.Abstractions/TemplateEngine/PromptTemplateConfig.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Core/Extensions/KernelSemanticFunctionExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Core/TemplateEngine/AggregatorPromptTemplateFactory.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.UnitTests/TemplateEngine/AggregatorPromptTemplateFactoryTests.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Core/TemplateEngine/AggregatorPromptTemplateFactory.cs
Show resolved
Hide resolved
stephentoub
reviewed
Nov 6, 2023
dotnet/src/SemanticKernel.Core/TemplateEngine/AggregatorPromptTemplateFactory.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Core/TemplateEngine/AggregatorPromptTemplateFactory.cs
Show resolved
Hide resolved
dotnet/src/Extensions/TemplateEngine.Basic/BasicPromptTemplateFactory.cs
Show resolved
Hide resolved
dotnet/src/Extensions/TemplateEngine.Basic/Extensions/BasicPromptTemplateFactoryExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Core/Extensions/KernelSemanticFunctionExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Core/Extensions/KernelSemanticFunctionExtensions.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/TemplateEngine/IPromptTemplateFactory.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Core/Extensions/KernelSemanticFunctionExtensions.cs
Outdated
Show resolved
Hide resolved
…//github.com/markwallace-microsoft/semantic-kernel into users/markwallace/Add_IPromptTemplateFactory
RogerBarreto
approved these changes
Nov 6, 2023
SergeyMenshykh
approved these changes
Nov 6, 2023
markwallace-microsoft
deleted the
users/markwallace/Add_IPromptTemplateFactory
branch
stephentoub
pushed a commit
to stephentoub/semantic-kernel
that referenced
this pull request
Nov 7, 2023
…e prompt rendering and template engine in dotnet samples (microsoft#3348) ### Motivation and Context Making this change to enable support for multiple prompt template formats See https://github.com/microsoft/semantic-kernel/blob/main/docs/decisions/0014-custom-prompt-template-formats.md ### Description ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 ## Summary This pull request updates the prompt rendering and template engine in the dotnet samples. Specifically, it replaces the PromptTemplate class with the BasicPromptTemplate class, updates the RunSemanticFunctionAsync method to use the new class, and removes the PromptTemplateEngineTests class which is now obsolete. Additionally, a new BasicPromptTemplateFactory class is introduced to create instances of the BasicPromptTemplate class. ## Changes - Replaced PromptTemplate class with BasicPromptTemplate class - Updated RunSemanticFunctionAsync method to use BasicPromptTemplate class - Removed PromptTemplateEngineTests class as it is now obsolete - Introduced BasicPromptTemplateFactory class to create instances of BasicPromptTemplate class --- *Powered by [Microsoft Semantic Kernel](https://github.com/microsoft/semantic-kernel)*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Making this change to enable support for multiple prompt template formats
See https://github.com/microsoft/semantic-kernel/blob/main/docs/decisions/0014-custom-prompt-template-formats.md
Description
Contribution Checklist
Summary
This pull request updates the prompt rendering and template engine in the dotnet samples. Specifically, it replaces the PromptTemplate class with the BasicPromptTemplate class, updates the RunSemanticFunctionAsync method to use the new class, and removes the PromptTemplateEngineTests class which is now obsolete. Additionally, a new BasicPromptTemplateFactory class is introduced to create instances of the BasicPromptTemplate class.
Changes
Powered by Microsoft Semantic Kernel