.Net: Locked version of Roslynator packages to 4.3.0 #3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrostruk
added
PR: ready for review
github-actions
bot
changed the title
RogerBarreto
approved these changes
Nov 2, 2023
This was referenced Nov 2, 2023
markwallace-microsoft
approved these changes
Nov 2, 2023
stephentoub
pushed a commit
to stephentoub/semantic-kernel
that referenced
this pull request
Nov 7, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Dependabot created a couple of PRs to upgrade version of `Roslynator.*` packages from 4.3.0 to 4.6.1. (Example: microsoft#3274) With this change, build pipeline is failing for .NET 6 (Details: https://github.com/microsoft/semantic-kernel/actions/runs/6657643874/job/18092783710?pr=3274):  This is happening because greater versions of `Roslyn` packages require greater versions of .NET SDK or Visual Studio (which ships together with .NET SDK):  Link: https://github.com/dotnet/roslyn/blob/main/docs/wiki/NuGet-packages.md#versioning This PR contains changes to lock version of `Roslynator` packages to 4.3.0. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 馃槃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Dependabot created a couple of PRs to upgrade version of
Roslynator.*packages from 4.3.0 to 4.6.1. (Example: #3274)With this change, build pipeline is failing for .NET 6 (Details: https://github.com/microsoft/semantic-kernel/actions/runs/6657643874/job/18092783710?pr=3274):
This is happening because greater versions of
Roslynpackages require greater versions of .NET SDK or Visual Studio (which ships together with .NET SDK):Link: https://github.com/dotnet/roslyn/blob/main/docs/wiki/NuGet-packages.md#versioning
This PR contains changes to lock version of
Roslynatorpackages to 4.3.0.Contribution Checklist